Bugzilla – Full Text Bug Listing
| Summary: | EMenuService should be in a platform neutral bundle | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Thomas Schindl <tom.schindl> |
| Component: | UI | Assignee: | Paul Webster <pwebster> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | bokowski, emoffatt, john.arthorne, Lars.Vogel, pwebster, remy.suen, wim.jongman |
| Version: | 4.4 | Keywords: | api |
| Target Milestone: | 4.4 M6 | ||
| Hardware: | PC | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Thomas Schindl
the bundle "org.eclipse.e4.ui.services" already exits For EMenuService it is provisional API that will probably change, once we take into account even one new platform. EMenuService should probably be dealt with in 4.1 PW Removing outdated target milestone. Can I get this back on the plan for 4.3 - the service is still marked as @noimplement/@noreference - I'd like to move it to to ui.services next to EContextMenu! (In reply to Thomas Schindl from comment #4) > Can I get this back on the plan for 4.3 - the service is still marked as > @noimplement/@noreference - I'd like to move it to to ui.services next to > EContextMenu! I don't think we have EContextMenu, maybe you mean EContextService? +1 for the move from me. EMenuService - is what I meant to be moved! (In reply to Thomas Schindl from comment #6) > EMenuService - is what I meant to be moved! Of course. Just the place to move to was unclear with EContextMenu. (In reply to Thomas Schindl from comment #6) > EMenuService - is what I meant to be moved! The only trouble I see with that is that it depends on MPopupMenu, that would add dependency on the model to the runtime services. PW I think the returning of MPopupMenu is not necessary, a boolean would do the Job as well (In reply to Thomas Schindl from comment #9) > I think the returning of MPopupMenu is not necessary, a boolean would do the > Job as well Strange, isn't it used? I'd like to examine it further. One potential solution would be to return Object (and call it a token). I'm not sure how practical that is. Plus if we're going to move it and generalize it, we need to update the doc to specify what it's supposed to do. PW I don't see why this should useful - i can always find the popup menu by querying the model - I've updated the JavaDoc in my gerrit review to state what the boolean value means. Released as http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=9d0bb5d66970c53ec82e9ad62472dfcac9c33897 and http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=978e108448ec5d5c43f42e6dc467b1a55b48cca0 Tom, please compose a message and send it to e4-dev (and probably copy platform-ui-dev) informing people this has changed and where it went to. Even though it was technically not API. PW Is this now API? Then we should also close Bug 412196. Am I correct assuming that everyone using the EMenuService:
@PostConstruct
public void postConstruct(Composite parent, EMenuService menuService) {
now has a broken build?
(In reply to Wim Jongman from comment #15) > Am I correct assuming that everyone using the EMenuService: > > @PostConstruct > public void postConstruct(Composite parent, EMenuService menuService) { > > now has a broken build? Yes, indeed. That's why we need a message to e4-dev. PW *** Bug 412196 has been marked as a duplicate of this bug. *** In 4.4.0.I20140303-2000 |