Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319398

Summary: JDT Object Icons (e.g. class_obj.gif) are not guideline conform
Product: [Eclipse Project] JDT Reporter: Michael Mühlberg <michael.muehlberg>
Component: UIAssignee: JDT-UI-Inbox <jdt-ui-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert
Version: 3.7   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Michael Mühlberg CLA 2010-07-09 10:23:11 EDT 
Build Identifier: I20100608-0911

Hello,

the User Interface Guidelines

http://wiki.eclipse.org/index.php/User_Interface_Guidelines#UI_Graphics_.283.x_updates.29

say for Model Objects:

The maximum image size is 16 x 15 pixels, but 15 x 15 is recommended. Model Object icons must be no greater than 15 pixels high. The empty pixels must be on the left and bottom, as shown here.

The guideline in the last sence is violated for several JDT icons (e.g. for class_obj.gif). The class_obj.gif icon has 2 empty pixel columns at the right hand side which is not guideline conform.

Why I'm reporting this issue is that we also want to design model icons and we want to reuse the JDT icons where possible for several use cases. But now I'm wondering whether our new icons should be guideline conform or whether they should be JDT conform.

What I prefer is that our icons get designed in a guideline conform way and that the JDT icons get adapted to the guidelines.

Ciao, Michael


Reproducible: Always

Steps to Reproduce:
1. unpack the plugin org.eclipse.jdt.ui_3.6.0.v20100602-1600.jar
2. go to icons\full\obj16
3. take a look at the icons, e.g. class_obj.gif and int_obj.gif
These (and others) are not guideline conform
Comment 1 Dani Megert CLA 2010-07-28 09:50:36 EDT 
The spec only says that the empty space of 1 pixel inside the 16x16 icon must be on the left and on the bottom. It doesn't say anything about having additional empty space i.e. there is no spec for icons that are smaller than the recommended size.
Comment 2 Michael Mühlberg CLA 2010-07-28 10:12:08 EDT 
(In reply to comment #1)
> The spec only says that the empty space of 1 pixel inside the 16x16 icon must
> be on the left and on the bottom. It doesn't say anything about having
> additional empty space i.e. there is no spec for icons that are smaller than
> the recommended size.

No, I don't agree.

The spec doesn't speak about 1 single line or column of pixels, it says "The empty pixels must be on the left and bottom" (plural form).

It is clear that every empty pixel (>= 1) must be on the left and bottom, not only 1, i.e. there IS indeed a spec for smaller icons.

I would therefore expect that the model object icons (class icon, for example) are located in the upper right corner.
Comment 3 Dani Megert CLA 2010-07-28 10:24:28 EDT 
As said it doesn't tell anything bout the case where the image is smaller. We won't change our images. So, closing as WONTFIX just in case that better fits your understanding of the spec ;-)