Bugzilla – Full Text Bug Listing
| Summary: | org.eclipse.virgo.kernel.dm is not used -- remove it | ||
|---|---|---|---|
| Product: | [RT] Virgo | Reporter: | Steve Powell <zteve.powell> |
| Component: | unknown | Assignee: | Chris Frost <eclipse> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | minor | ||
| Priority: | P3 | CC: | eclipse, glyn.normington |
| Version: | unspecified | ||
| Target Milestone: | 2.1.0.M05-incubation | ||
| Hardware: | PC | ||
| OS: | Mac OS X - Carbon (unsup.) | ||
| Whiteboard: | |||
*** Bug 319099 has been marked as a duplicate of this bug. *** Whoops -- looks like I raised both of them! :-) Thanks for spotting this, Glyn. Steve's note from the duplicate bug: The bundle is installed and started when kernel starts up, and publishes (via spring) some services against some interfaces (in org.eclipse.virgo.kernel.module). Neither the services nor the interfaces are used. There is nothing else in this bundle (not even tests). It (and the interfaces it uses) can be removed. The bundle should also be removed from the kernel launch list (in main and test config files). NOTE: Spring beans set up the bundle -- there is no activator -- and there are some service references there also which are not used anywhere. This is a minor performance bug. Kernel.dm has been removed, all references to it in kernel and other repos have also been deleted. closing RC1 is planned instead of milestone 5. |
We need to check that this isn't actually used at all, of course. There are many references in the code to it, however, and these will all need to be removed to keep tests running correctly. Here is a snapshot of the files that contain the string "org.eclipse.virgo.kernel.dm": In org.eclipse.virgo.kernel/ ... build-kernel/lib/org.eclipse.virgo.kernel.launch.properties build-kernel/build.xml org.eclipse.virgo.kernel/ivy.xml org.eclipse.virgo.kernel.dm/build.xml org.eclipse.virgo.kernel.dm/template.mf org.eclipse.virgo.kernel.dm/.project org.eclipse.virgo.kernel.dm/src/main/java/org/eclipse/virgo/kernel/dm/internal/StandardServiceProxyInspector.java org.eclipse.virgo.kernel.dm/src/main/java/org/eclipse/virgo/kernel/dm/internal/StandardBundleDelegatingClassLoaderFactory.java org.eclipse.virgo.kernel.dm/src/main/resources/META-INF/spring/kernel-dm-context.xml org.eclipse.virgo.kernel.test/ivy.xml org.eclipse.virgo.kernel.test/src/test/java/org/eclipse/virgo/kernel/dm/test/ModuleBeanFactoryPostProcessorTests.java org.eclipse.virgo.kernel.test/src/test/resources/META-INF/MANIFEST.MF org.eclipse.virgo.kernel.test/src/test/resources/test.config.properties org.eclipse.virgo.kernel.deployer.test/.classpath org.eclipse.virgo.kernel.deployer.test/src/test/resources/META-INF/test.config.properties org.eclipse.virgo.kernel.deployer.test/src/test/resources/META-INF/spring256.test.config.properties In org.eclipse.virgo.apps/ org.eclipse.virgo.apps.repository.test/src/test/resources/META-INF/test.config.properties In org.eclipse.virgo.web/ org.eclipse.virgo.web.core/ivy.xml org.eclipse.virgo.web.test/src/test/resources/META-INF/test.config.properties In org.eclipse.virgo.documentation/ user-guide/src/log-codes.xml Note: The interfaces ServiceProxyInspector and BundleDelegatingClassLoaderFactory are defined in org.eclipse.virgo.kernel.module which is a package in org.eclipse.virgo.kernel.deployer. ...dm creates implementations (and beans) for these interfaces, but no-one uses them. If the project ....dm is removed then the interfaces can be as well.