Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319355

Summary: Toolbar and CTabRendering gradients should have same height (in pixels or percentage)
Product: [Eclipse Project] Platform Reporter: Stefan Mücke <s.muecke>
Component: UIAssignee: Platform-UI-Inbox <Platform-UI-Inbox>
Status: CLOSED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: gheorghe, remy.suen, susan
Version: 4.2   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard: stalebug
Bug Depends on:    
Bug Blocks: 293481    
Attachments:
Description Flags
Screenshot
none
Screenshot 2 (tweaked)
none
Screenshot: different heights of toolbar gradients none

Description Stefan Mücke CLA 2010-07-09 05:39:17 EDT
Created attachment 173845 [details]
Screenshot

See screenshot for details.
Comment 1 Stefan Mücke CLA 2010-07-17 06:45:06 EDT
Susan, can you have a look at this? Is this really intended?

I still have this look with the latest build (I20100716).
Comment 2 Susan McCourt CLA 2010-07-19 11:44:47 EDT
The gradients are intentional.  They differ slightly per theme.  Are you saying you don't like having a gradient?  Or you want the gradient to be smoother?  We are using the images in org.eclipse.platform/images (win7.png, winXPBlue.png, etc.).
Comment 3 Stefan Mücke CLA 2010-07-19 12:08:41 EDT
Created attachment 174643 [details]
Screenshot 2 (tweaked)

Susan, please have a look at the two screenshots. In the second one, I have tweaked the image winXPBlue.PNG to show you the difference. I think the lower part of the gradient should have continued with the same color as the end of the gradient.

Please also see bug 318801. I have just discovered that the dot rendered at a regular distance comes from the image.

I am wondering why images are used for the toolbar background, while the tab headers are rendered using the gradient values specified in the CSS file.
Comment 4 Susan McCourt CLA 2010-07-19 12:56:15 EDT
The gradient getting dark and then changing and getting lighter again is intentional.  This was spec'ed by our graphic designer (for example, there is a design mockup at http://wiki.eclipse.org/E4/CSS/Visual_Design).

(In reply to comment #3)

> 
> I am wondering why images are used for the toolbar background, while the tab
> headers are rendered using the gradient values specified in the CSS file.

This is really just a product of the history/evolution of the design.  The toolbar gradients have been tweaked over the course of the design and it was simplest to grab the gradient from the designer mockups.  The tab headers were originally solid colors or simple gradients.  It was near the end of the design process that they evolved to look more like the toolbar.

I'm going to mark this bug as a blocker for the overall "new look" bug.  This is how we are tracking feedback about the design.
Comment 5 Susan McCourt CLA 2010-08-16 15:26:38 EDT
We are going to close this bug as "WONTFIX" for now, since the design "bump" in the gradient is intentional.  If we see a lot of similar feedback in the future, we could reopen.  

(And of course, we are going to encourage people to try alternate stylesheets as well.)
Comment 6 Stefan Mücke CLA 2010-08-16 15:45:20 EDT
Created attachment 176716 [details]
Screenshot: different heights of toolbar gradients

Susan, I would like to point you to another aspect I feel looks broken. The gradients in the main and local toolbars have a different height. Neither the absolute height in pixels nor the percentage height agree. Reopen?
Comment 7 Susan McCourt CLA 2010-08-16 16:40:44 EDT
(In reply to comment #6)
> Created an attachment (id=176716) [details]
> Screenshot: different heights of toolbar gradients
> 
> Susan, I would like to point you to another aspect I feel looks broken. The
> gradients in the main and local toolbars have a different height. Neither the
> absolute height in pixels nor the percentage height agree. Reopen?

sure, can you retitle the bug to capture the specific issue?
Comment 8 Stefan Mücke CLA 2010-08-17 05:54:08 EDT
Updated the title and reopened.
Comment 9 Lars Vogel CLA 2019-11-14 03:51:44 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.