Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319349

Summary:	Fragment-Host does not conform strictly to the OSGi spec
Product:	[Eclipse Project] Equinox	Reporter:	Glyn Normington <glyn.normington>
Component:	Framework	Assignee:	equinox.framework-inbox <equinox.framework-inbox>
Status:	RESOLVED INVALID	QA Contact:
Severity:	normal
Priority:	P3	CC:	tjwatson
Version:	3.6
Target Milestone:	---
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description Glyn Normington

2010-07-09 04:47:26 EDT

Equinox appears to allow "version" as a synonym for "bundle-version" on Fragment-Host. Someone coded "version" into a bundle in the SpringSource Enterprise Bundle Repository and only now, when someone is trying to run this bundle on Felix, have we found out that the bundle is broken.

See https://issues.apache.org/jira/browse/FELIX-2466 for background.

Equinox should tighten up its default behaviour to conform closely with the OSGi spec for Fragment-Host unless the OSGi spec can be relaxed.

Comment 1 Thomas Watson

2010-07-09 09:21:57 EDT

This is not a bug in Equinox, instead it is a bug in Felix.  Equinox is complying with the specification.  I discussed this with Richard Hall and he agrees.  See his comments in https://issues.apache.org/jira/browse/FELIX-2466.  The "version" attribute is not a recognized attribute for the Fragment-Host header.  The following two Fragment-Host headers are equivalent according to the specification:

Fragment-Host: foo.host; version="[1.0,1.1)"
Fragment-Host: foo.host

In the first case "version" is not a recognized matching attribute.  Arbitrary matching attributes are only supported on Import-Package/Export-Package.  The specification also states that unrecognized attributes/directives should be ignored by the framework.  So in this case Equinox simply ignores the version attribute.  This means the fragment will be able to attach to any version of the host foo.host.

In retrospect, I am not sure why the OSGi specification decided to use the "bundle-version" attribute for Require-Bundle and Fragment-Host instead of simply "version".

Comment 2 Glyn Normington

2010-07-09 09:36:47 EDT

Hi Tom

Re-reading Richard's comments I now understand and agree this is not a bug in Equinox. Sorry to have troubled you.

Glyn

Comment 3 Thomas Watson

2010-07-09 09:59:53 EDT

(In reply to comment #2)
> Hi Tom
> 
> Re-reading Richard's comments I now understand and agree this is not a bug in
> Equinox. Sorry to have troubled you.
> 
> Glyn

No problem Glyn.  I am not sure what tooling you use to create your manifests.  If it is PDE, then an argument could be made that PDE should flag this as a warning/error.  If that is the case you could consider reopening this bug and moving it to PDE->UI.