Bugzilla – Full Text Bug Listing
| Summary: | [build] show Hudson views in build plan selection | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Steffen Pingel <steffen.pingel> | ||||||||||
| Component: | Mylyn | Assignee: | Markus Knittig <markus> | ||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||
| Severity: | enhancement | ||||||||||||
| Priority: | P3 | CC: | markus | ||||||||||
| Version: | unspecified | ||||||||||||
| Target Milestone: | 0.7 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Linux | ||||||||||||
| Whiteboard: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Steffen Pingel
Nested build jobs? Haven't seen these. Or do you mean actual builds? Views should definitely be there, but how to show these? A job can be in multiple views, so showing that in a tree view might be confusing... Also not sure how generic this stuff is (and overriding the settings page is IIRC currently not possible in the Hudson connector). Filtering should be done in the commons settings page. You mean filtering on the retrieved results, right? Yes, I mean the views. I agree that it could be confusing to show these in the tree due to the potential for duplicates and we might be better of leaving them out for now and adding a filter instead. It should be fairly straight forward to add that to the generic build page implementation. For the views it would be nice to have them in the Hudson connector API even if we are not yet going to use them. Just to clarify for filtering I was thinking of using a FilteredTree. I have attached a context that points to CheckboxFilteredTree which has an example of that. I don't see any attached context. I found some implementations of @CheckboxFilteredTree@. The problem I have right now is that @TreeColumnLayout@ doesn't work with that, because it's tightly coupled to @Tree@. I tried overriding @TreeColumnLayout@, but that isn't working and probably a bad idea anyway. Any hints? Here is the context. Do we need multiple columns in the tree or can we get away without a special layout? How does PDE deal with that for the launch configurations dialog? Created attachment 175022 [details]
mylyn/context/zip
Removed the layout code, all seems to be fine so far. Now I just have to figure out why the @CheckboxFilteredTree@ is empty even though there should be items... Created attachment 175670 [details]
Filtering for build plans
Finally got it...
Created attachment 175671 [details]
mylyn/context/zip
Created attachment 175680 [details]
fix
Thanks. I ran into some problem with your patch. If the list was filtered it would discard the checked state of the elements. I have committed a change that uses an ICheckStateProvider which does stores the checked state in the model instead of using the button controls. I have assigned the bug to you nevertheless since you did a lot of investigation here. The checked elements need to be saved and restored after the filtering. Not a big problem... BTW: The project doesn't work after the latest CVS Update. The class @CredentialsFactory@ from commons.repository is missing. Local or global problem? (In reply to comment #12) > BTW: The project doesn't work after the latest CVS Update. The class > @CredentialsFactory@ from commons.repository is missing. Local or global > problem? I have verified that the class is in CVS but anonymous CVS seems to lack behind again. Unfortunately there is not much we can do about that. Let me know if the class does not appear within the next 48 hours and I'll contact the webmasters. |