Bugzilla – Full Text Bug Listing
| Summary: | review custom workflow repository settings UI | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Robert Elves <robert.elves> | ||||||||||||||
| Component: | Mylyn | Assignee: | Mylyn Inbox <mylyn-inbox> | ||||||||||||||
| Status: | RESOLVED DUPLICATE | QA Contact: | |||||||||||||||
| Severity: | enhancement | ||||||||||||||||
| Priority: | P3 | CC: | charley.wang, robert.elves | ||||||||||||||
| Version: | unspecified | ||||||||||||||||
| Target Milestone: | --- | ||||||||||||||||
| Hardware: | All | ||||||||||||||||
| OS: | All | ||||||||||||||||
| Whiteboard: | |||||||||||||||||
| Bug Depends on: | |||||||||||||||||
| Bug Blocks: | 259291 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Robert Elves
Hi, I wrote up a very brief guide to the current UI at the top of my User talk page on Eclipse: http://wiki.eclipse.org/User_talk:Charley.wang.gmail.com I can migrate this into the Mylyn User Guide or another more appropriate location if it is all right. Comments and suggestions are welcome. -Charley Thanks Charley! We'll add that to the user guide once we update it for 3.5. Currently it sill contains the 3.4 content. We discussed this on a call and determined that it might be best to simply remove the workflow settings and always default to auto-detection: 1. Check if XML-RPC is available 2. Check for a work flow properties file on the server, e.g. "https://bugs.eclipse.org/bugs/workflow.properties" 3. Fall-back to default workflow In addition we could check for a system property, e.g. "org.eclipse.mylyn.bugzilla.workflow.bugs.eclipse.org", that could point to a local file to support advanced users. (In reply to comment #3) > We discussed this on a call and determined that it might be best to simply > remove the workflow settings and always default to auto-detection: > > 1. Check if XML-RPC is available > 2. Check for a work flow properties file on the server, e.g. > "https://bugs.eclipse.org/bugs/workflow.properties" > 3. Fall-back to default workflow > > In addition we could check for a system property, e.g. > "org.eclipse.mylyn.bugzilla.workflow.bugs.eclipse.org", that could point to a > local file to support advanced users. This definitely makes more sense as a UI flow -- having the file available on the Bugzilla server is much better than asking users to maintain their own. I would be happy to take a look at doing the changes this week or next, if nobody else has done so :) -C Created attachment 176068 [details]
Patch for 319295
Includes the core component and a minor change to the UI. Changes the default Bugzilla behaviour but does not affect the frontend.
Created attachment 176069 [details]
mylyn/context/zip
Created attachment 176070 [details]
UI Patch for 319295
Removes unused portions of the Mylyn Bugzilla Repository Preference page that were used for Custom Workflow settings
Created attachment 176071 [details]
Tests for 319295
Makes a slight change to the way Custom Repository tests are set up so that existing tests will not break with the new behaviour
The current workflow goes: 1. Check file specified by system property org.eclipse.mylyn.bugzilla.desciptorFile 2. Check file specified by the Bugzilla installation at getRepositoryUrl() + "/workflow.properties" 3. Check XMLRPC 4. Default workflow I was thinking this would let an advanced user override all settings, allow a Bugzilla maintainer to override XMLRPC settings, and still allow XMLRPC to override default workflow. I'd be happy to change it use XMLRPC first, if you prefer :) I need to regenerate the UI patch, currently one of the hunks is being ignored which results in 10 lines not being properly deleted near the end of BugzillaRepositorySettingsPage. Sounds reasonable, particularly since XML-RPC is still work in progress. Could you make a single patch that includes all changes? (In reply to comment #10) > Sounds reasonable, particularly since XML-RPC is still work in progress. Could > you make a single patch that includes all changes? Sure, but it will be > 250 lines, is that all right? Created attachment 176577 [details]
Combined patch
Combines the three patches above, rebased to the latest Bugzilla from HEAD. Most of the changes just involve removing UI elements from the Bugzilla Repository Properties page.
Created attachment 176578 [details]
mylyn/context/zip
For the Aug 13-2010 2:17PM patch, the Bugzilla test suite does run correctly after the patch is applied. Please advise if there are any further steps I need to take for this patch or if I should change the workflow further. Let's track this on bug 341829. *** This bug has been marked as a duplicate of bug 341829 *** |