Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319185

Summary:

'Apply' button on 'Manifest Entries' tab reverts changes on first use

Product:

[WebTools] WTP Common Tools

Reporter:

Aidyl Kareh <amkareh>

Component:

wst.common

Assignee:

Aidyl Kareh <amkareh>

Status:

RESOLVED FIXED

QA Contact:

Carl Anderson <ccc>

Severity:

normal

Priority:

CC:

amkareh

Version:

unspecified

Flags:

amkareh: pmc_approved? (david_williams)
amkareh: pmc_approved? (raghunathan.srinivasan)
amkareh: pmc_approved? (naci.dai)
deboer: pmc_approved+
amkareh: pmc_approved? (neil.hauge)
amkareh: pmc_approved? (kaloyan)
ccc: review+

Target Milestone:

3.2.1

Hardware:

OS:

Windows XP

Whiteboard:

PMC_approved

Attachments:

Description	Flags
Proposed Patch	ccc: iplog+

Description Aidyl Kareh

2010-07-07 15:46:53 EDT

Build Identifier: WTP 3.2.1

Currently changes made to the 'Manifest Entries' table in the 'Manifest Entries' tab of the 'Deployment Assembly' properties page are being reverted on the first use of the 'Apply' button.

Steps to reproduce:
1) Create an EAR 6 project with all default modules.
2) Go to the 'Manifest Entries' tab of the 'Deployment Assembly' properties page for the Web project.
3) Add a manifest entry to the EJB project and click 'Apply' (the changes are reverted; without closing the window, if you repeat the add and click 'Apply' the changes persist.)

Reproducible: Always

Comment 1 Aidyl Kareh

2010-07-07 15:48:20 EDT

Created attachment 173702 [details]
Proposed Patch

Patch fixes the issue by setting the previousManifest variable to the initial manifest file when the window is opened.

Comment 2 Carl Anderson

2010-07-07 16:28:05 EDT

I approve - a simple, high quality fix for an ugly problem.

Comment 3 Aidyl Kareh

2010-07-07 16:35:39 EDT

    * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

Currently changes made to the 'Manifest Entries' table in the 'Manifest Entries' tab of the 'Deployment Assembly' properties page are being reverted on the first use of the 'Apply' button when the window is opened.

    * Is there a work-around? If so, why do you believe the work-around is insufficient? 

No.

    * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

Tested through UI.

    * Give a brief technical overview. Who has reviewed this fix? 

Patch fixes the issue by setting the previousManifest variable to the initial manifest file when the window is opened. Right now it thinks that there was no initial manifest file, so it clears the table to load the contents of the manifest file. Reviewed by Carl Anderson.

    * What is the risk associated with this fix? 
Low.

Comment 4 Carl Anderson

2010-07-07 18:36:36 EDT

Committed to HEAD for WTP 3.2.1 and WTP 3.3