Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319183

Summary:

JavaScript Debug keybinding hides Quick Access in Debug perspective

Product:

[WebTools] JSDT

Reporter:

Eric Rizzo <eclipse-bugs>

Component:

Debug

Assignee:

Michael Rennie <Michael_Rennie>

Status:

VERIFIED FIXED

QA Contact:

Simon Kaegi <simon_kaegi>

Severity:

major

Priority:

CC:

thatnitind

Version:

3.2

Flags:

thatnitind: review+

Target Milestone:

3.2.2

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
proposed fix	none

Description Eric Rizzo

2010-07-07 15:13:29 EDT

I just noticed in Helios Java EE package, a new keyboard shortcut has been set up for Command+3 (Ctrl+3 for you Windows users). It's bound to a command named "Open Source" in the "JavaScript Debug" category, and "When" is set to "Debug."
The problem is that Command/Ctrl+3 is already bound to the Quick Access command, which is universal across the workbench and is a long-standing, well-known shortcut. Having this new one breaks Quick Access when in the Debug perspective; disabling the "Open Source" binding restores Quick Access functionality.

Comment 1 Michael Rennie

2010-07-12 10:20:49 EDT

Created attachment 174025 [details]
proposed fix

One proposed fix would be to change the binding to Ctrl+Shift+3 which does not collide with any of the platform bindings.

Comment 2 Nitin Dahyabhai

2010-07-12 10:55:02 EDT

* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

Subverting preexisting key bindings is very aggravating to long-time users, plus when debugging any languages other than JS, it looks like Quick Access simply isn't working since our Command does nothing for them.

* Is there a work-around? If so, why do you believe the work-around is insufficient? 

Only workaround is to rebind the command, although it may be difficult to find which one is active if you're not already familiar with the preference page or using Show Key Assist.

* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 

Tested manually.

* Give a brief technical overview. Who has reviewed this fix? 

Changes the default keybinding for the command that shows the JavaScript source for the selected script element.  I've reviewed it.

* What is the risk associated with this fix? 
None.

Comment 3 Nitin Dahyabhai

2010-07-12 11:05:15 EDT

We don't need PMC review for 3.2.2, we just need to wait for the builds to start.

Comment 4 Michael Rennie

2010-07-12 13:36:33 EDT

applied fix to HEAD, will apply to 3.2.2 when the builds start for 3.2.2

Comment 5 Michael Rennie

2010-08-03 14:06:35 EDT

Applied fix to 3.2.2