Bug 319178

Comment 1 Jesse McConnell 2010-07-07 14:36:51 EDT

you indicate this is always reproducible..

I have never seen these we remotely reproducible so if they actually are for you please indicate what your java version is and what operating system your on (really vista?)

thanks

Comment 2 Dmytro Pishchukhin 2010-07-07 14:45:41 EDT

(In reply to comment #1)
> you indicate this is always reproducible..
> 
> I have never seen these we remotely reproducible so if they actually are for
> you please indicate what your java version is and what operating system your on
> (really vista?)
> 
> thanks

It's also strange for me to see those failures. I've tried trunk and 7.1.5 tag. Result is the same.

C:\Projects\jetty>c:\tools\maven-2\bin\mvn -v
C:\Projects\jetty>set MAVEN_OPTS=-Xmx512m -XX:MaxPermSize=256m
Apache Maven 2.2.1 (r801777; 2009-08-06 21:16:01+0200)
Java version: 1.6.0_18
Java home: C:\Tools\jdk1.6.0\jre
Default locale: en_GB, platform encoding: Cp1252
OS name: "windows vista" version: "6.0" arch: "x86" Family: "windows"

Regards,
Dmytro

Comment 3 Dmytro Pishchukhin 2010-07-07 14:49:55 EDT

(In reply to comment #2)
> (In reply to comment #1)
> > you indicate this is always reproducible..
> > 
> > I have never seen these we remotely reproducible so if they actually are for
> > you please indicate what your java version is and what operating system your on
> > (really vista?)
> > 
> > thanks
> 
> It's also strange for me to see those failures. I've tried trunk and 7.1.5 tag.
> Result is the same.
> 
> C:\Projects\jetty>c:\tools\maven-2\bin\mvn -v
> C:\Projects\jetty>set MAVEN_OPTS=-Xmx512m -XX:MaxPermSize=256m
> Apache Maven 2.2.1 (r801777; 2009-08-06 21:16:01+0200)
> Java version: 1.6.0_18
> Java home: C:\Tools\jdk1.6.0\jre
> Default locale: en_GB, platform encoding: Cp1252
> OS name: "windows vista" version: "6.0" arch: "x86" Family: "windows"
> 
> Regards,
> Dmytro

I've tried to build only jetty-util module and I've got only org.eclipse.jetty.util.log.LogTest.logContains(LogTest.java:69)
 failure.

Regards,
Dmytro

Comment 4 Dmytro Pishchukhin 2010-07-08 03:59:27 EDT

FYI: I can reproduce this test failure at my work PC also:

D:\Users\DmytroPishchukhin\Projekte\jetty>mvn -v
Apache Maven 2.2.1 (r801777; 2009-08-06 21:16:01+0200)
Java version: 1.6.0_13
Java home: D:\Users\DmytroPishchukhin\Tools\jdk1.6.0_13\jre
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows vista" version: "6.0" arch: "x86" Family: "windows"

Comment 5 Jesse McConnell 2010-09-14 15:30:03 EDT

guess I'll have to track down a vista machine to try and build jetty with

Comment 6 Flo 2010-11-06 13:56:11 EDT

Hi!
I had the same problem with vista (but with jetty-8.0.0.M1)

There seems to be a problem with windows and unix newlines mixed up

adding the lines
        err = err.replaceAll("\r\n","\n");
        text = text.replaceAll("\r\n","\n");
to LogTest.java
is a workaround

---
    private void logContains(String text)
    {
        _pout.flush();
        String err = _out.toString();
        _out.reset();

        err = err.replaceAll("\r\n","\n");
        text = text.replaceAll("\r\n","\n");
        
        if (err.indexOf(text)>=0)
            return;
        
        _orig.println("FAIL '"+text+"' not in '"+err+"'");

        assertTrue(false);
    }
---

Comment 7 Jesse McConnell 2011-01-12 16:35:48 EST

[rune]trunks/jetty> svn commit -m "Bug 319178 test failure fix in jetty-util on windows" jetty-util/src/test/java/org/eclipse/jetty/util/log/LogTest.java VERSION.txt
Sending        VERSION.txt
Sending        jetty-util/src/test/java/org/eclipse/jetty/util/log/LogTest.java
Transmitting file data ..
Committed revision 2656.

Thanks Flo for figuring out what the issue was!

cheers