Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319170

Summary: Add breakpoint support to RDT editor
Product: [Tools] PTP Reporter: Greg Watson <g.watson>
Component: RDTAssignee: Project Inbox <ptp-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: recoskie, vivkong
Version: 4.0.1Flags: recoskie: review+
Target Milestone: ---   
Hardware: Macintosh   
OS: Mac OS X   
Whiteboard:
Attachments:
Description Flags
patch to add debug actions
none
updated patch none

Description Greg Watson CLA 2010-07-07 14:07:57 EDT 
The following patch adds actions to the RDT editor to make it consistent with the CDT editor. This allows debuggers to contribute breakpoint actions to the editor.

The patch adds two dependencies: org.eclipse.debug.ui and org.eclipse.cdt.debug.ui.

Please let me know if this is ok and I'll commit to 4.0 and HEAD.
Comment 1 Greg Watson CLA 2010-07-07 14:08:42 EDT 
Created attachment 173692 [details]
patch to add debug actions
Comment 2 Chris Recoskie CLA 2010-07-12 08:37:13 EDT 
Hmmm... I know we had problems with the CDT breakpoint functionality consistently failing on the remote editor because it does an explicit instanceof check to see if it's the CDT local editor.  So even with this, you might not get what you want.

The one thing to check is that we can still properly contribute support for other debuggers without things still conflicting.  Vivian can you try this out and see if there any conflicts with our debugger?
Comment 3 Greg Watson CLA 2010-08-16 09:58:25 EDT 
Is this ok to commit?
Comment 4 Chris Recoskie CLA 2010-08-16 11:43:13 EDT 
I tried applying this patch to my ptp_4_0 workspace, and it complained:

Description	Resource	Path	Location	Type
Unsatisfied version constraint: 'org.eclipse.debug.ui: 3.7.0'	MANIFEST.MF	org.eclipse.ptp.rdt.ui/META-INF	line 39	Plug-in Problem

Does it really require that version of debug.ui?

There are some API changes that happened on CDT HEAD recently, so we don't have a working RDT right now on HEAD for me to test.
Comment 5 Greg Watson CLA 2010-08-16 14:02:29 EDT 
No that constraint is not required. I guess it was automatically added.
Comment 6 Greg Watson CLA 2010-08-24 18:19:51 EDT 
Created attachment 177376 [details]
updated patch
Comment 7 Chris Recoskie CLA 2010-09-08 14:52:44 EDT 
I haven't been able to try out the patch, but I think it will be ok.  It might cause some unwanted actions to show up in our IBM product, but we should be able to hide those using capabilities.
Comment 8 Greg Watson CLA 2010-09-08 17:48:17 EDT 
Applied to 4.0 and HEAD.