Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319169

Summary:

[UI] active parts in Detached windows prevent activating a part in the main window

Product:

[Eclipse Project] e4

Reporter:

Eric Moffatt <emoffatt>

Component:

Assignee:

Remy Suen <remy.suen>

Status:

RESOLVED FIXED

QA Contact:

Eric Moffatt <emoffatt>

Severity:

normal

Priority:

CC:

remy.suen

Version:

unspecified

Target Milestone:

1.0 RC2

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Fix the DW's context to be the perspective and also fix the part service's 'isInContainer' to check DW's	none
Child windows compensation patch v2	none

Description Eric Moffatt

2010-07-07 13:34:48 EDT

Start with a fresh WS
Detach the Outline view using DnD

Now you can no longer activate any part in the main window (i.e. Package Explorer).

The cause seems to be that the 'rootContainer' has become the DW's MTrimmedWindow rather than the DW's containing MPerspective. This causes the PartService's 'activate' to fail the 'isInContainer()' test...

Comment 1 Eric Moffatt

2010-07-07 13:53:13 EDT

Created attachment 173687 [details]
Fix the DW's context to be the perspective and also fix the part service's 'isInContainer' to check DW's


NOTE: the PartService fix only checks the DW's of a Perspective...it should likely also check for DW's directly against an MWindow...

Comment 2 Eric Moffatt

2010-07-07 13:53:55 EDT

Disregard the previous 'NOTE', the patch includes checking DW's of MWindow's as well...

Comment 3 Remy Suen

2010-07-07 14:08:53 EDT

Created attachment 173693 [details]
Child windows compensation patch v2

Updated the patch to also consider the container itself as being a perspective or a window. Also added two new tests.

Comment 4 Remy Suen

2010-07-07 14:09:49 EDT

(In reply to comment #3)
> Created an attachment (id=173693) [details]
> Child windows compensation patch v2

Fix released to CVS HEAD.