Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319146

Summary:	Refactoring of DefaultTextEditComposer
Product:	[Modeling] TMF	Reporter:	Johan Wannheden <johan.wannheden>
Component:	Xtext	Assignee:	Project Inbox <tmf.xtext-inbox>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	sebastian.zarnekow
Version:	unspecified	Flags:	sebastian.zarnekow: helios+
Target Milestone:	SR1
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description Johan Wannheden

2010-07-07 11:26:45 EDT

Build Identifier: 20100218-1602

The implementation of org.eclipse.xtext.ui.editor.model.edit.DefaultTextEditComposer.getObjectEdits() is a private method that does not allow to set the SaveOptions when serializing. In order to use custom SaveOptions, it is required to overwrite getTextExit() by providing an own TextEditComposer and to delegate to a custom getObjectEdits() method.

getObjectEdits() should not be private in order to make the class more easily extendable.

Reproducible: Always

Comment 1 Sebastian Zarnekow

2010-08-24 08:48:21 EDT

Fixed in HEAD.

Comment 2 Karsten Thoms

2017-09-19 16:29:16 EDT

Closing bug which were set to RESOLVED before Eclipse Neon.0.