Bugzilla – Full Text Bug Listing
| Summary: | [NLS] Problems reported directly by JSP translation aren't externalized | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Source Editing | Reporter: | Nitin Dahyabhai <thatnitind> | ||||
| Component: | jst.jsp | Assignee: | Nitin Dahyabhai <thatnitind> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Nitin Dahyabhai <thatnitind> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | david_williams, melickm, nsand.dev | ||||
| Version: | 3.2 | Flags: | david_williams:
pmc_approved+
thatnitind: pmc_approved? (raghunathan.srinivasan) thatnitind: pmc_approved? (naci.dai) thatnitind: pmc_approved? (deboer) thatnitind: pmc_approved? (neil.hauge) thatnitind: pmc_approved? (kaloyan) nsand.dev: review+ |
||||
| Target Milestone: | 3.2.1 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | PMC_approved WI49473 | ||||||
| Attachments: |
|
||||||
|
Description
Nitin Dahyabhai
Created attachment 173604 [details]
proposed patch, no new strings added
Looks like a good fix to me. * Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. Untranslated strings are bad. More than one of the generated problems doesn't even supply a message string in 3.2.0. * Is there a work-around? If so, why do you believe the work-around is insufficient? No workaround. * How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? Manually tested, breaks no existing BVT. * Give a brief technical overview. Who has reviewed this fix? Changes reported strings to use existing externalized versions. * What is the risk associated with this fix? Low. Externalizing strings is important, so I think we should fix. How long have these been broken? Are these new validation messages? Can you think of any test to do in future to make sure these type of non-externalized strings don't sneak in? Maybe change project settings to flag as 'error'? (In reply to comment #4) > Externalizing strings is important, so I think we should fix. How long have > these been broken? Are these new validation messages? Can you think of any test > to do in future to make sure these type of non-externalized strings don't sneak > in? Maybe change project settings to flag as 'error'? That may be the only way to be sure we catch them. These have actually been around since 3.1 was in development, but validation messages being externalized aren't quite as trivial to verify as other elements of our UI. The validation checks aren't new, and neither are the externalized messages we're using in this patch (no changes were made to a .properties file), they just weren't connected properly. Released to HEAD and maintenance. |