Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 319048

Summary:

Utility code may leak Image handles

Product:

[WebTools] WTP Source Editing

Reporter:

Nick Sandonato <nsand.dev>

Component:

wst.xml

Assignee:

Nick Sandonato <nsand.dev>

Status:

RESOLVED FIXED

QA Contact:

Nitin Dahyabhai <thatnitind>

Severity:

major

Priority:

CC:

ccc

Version:

3.0.5

Flags:

thatnitind: review+

Target Milestone:

3.0.5 P

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
patch	none
patch update	none

Description Nick Sandonato

2010-07-06 15:50:48 EDT

The CMImageUtility class has the potential to leak Image handles.

Calls to CMImageUtility#getImage() will retrieve a cached image descriptor, but will create a new Image from the descriptor every time. Each call with then result in one leaked Image handle.

Comment 1 Nick Sandonato

2010-07-06 16:11:46 EDT

Created attachment 173594 [details]
patch

Comment 2 Nick Sandonato

2010-07-07 14:38:56 EDT

Created attachment 173697 [details]
patch update

Updated the patch to utilize the ImageRegistry entirely.

Comment 3 Carl Anderson

2010-07-09 17:12:28 EDT

Committed to R3_0_5_patches