Bugzilla – Full Text Bug Listing
| Summary: | [WorkingSets] Provide a preference to set size of the list of most recently used working sets | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Hitesh <hsoliwal> | ||||||||
| Component: | UI | Assignee: | Oleg Besedin <ob1.eclipse> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | Oleg Besedin <ob1.eclipse> | ||||||||
| Severity: | enhancement | ||||||||||
| Priority: | P3 | CC: | bokowski, daniel_megert, mukund, ob1.eclipse, pwebster, raji, remy.suen | ||||||||
| Version: | 3.6 | Keywords: | api | ||||||||
| Target Milestone: | 3.7 M6 | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
Created attachment 190210 [details]
Patch
The patch adds the following APIs:
IWorkingSetManager#
public void setRecentWorkingSetsLength(int length);
public int getRecentWorkingSetsLength();
(The IWorkingSetManager is marked as "no implement" and got a new method last time in 3.4.)
The patch exposes new MRU preference in the General -> Workspace preference page.
The patch adds JUnit IWorkingSetManagerTest№testRecentWorkingSetsLength().
If anybody want to review the patch, please do it soon so we can make the change in time for M6.
Oleg, I think the bug was wrongly filed by Hitesh. The client only requested API to change the size/limit of recently used working sets. Having said that, if Platform UI thinks it makes sense to also add UI for that, OK. However, the 'Workspace' page is wrong as that page should only contain workspace and not workbench (i.e. UI) related things. "Show up to this number of recent working sets:" sounds a bit sloppy to me - but I'm not a native speaker. Created attachment 190434 [details]
Patch
Updated patch:
- removed UI preferences page
- changed MRU preference to be shown via IWorkbenchPreferenceConstants.RECENTLY_USED_WORKINGSETS_SIZE
Patch applied to CVS Head. Thanks to all people who helped! Verified that new IWorkingSetManager APIs are present and functioning in the I20110307-2110. Oleg, I reopen this bug as it is not included in R4_development. Not sure whether this is not needed in 4.x or whether this just got lost. (In reply to comment #6) > Oleg, I reopen this bug as it is not included in R4_development. Not sure > whether this is not needed in 4.x or whether this just got lost. Sorry, I meant to reopen another bug. |
Created attachment 173449 [details] Patch V01 Provide a preference to set the size of the list of most recently used working sets as . Attached is a potential patch.