Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 318903

Summary: [UI] Search Bar and Perspective switcher should always be on the same line
Product: [Eclipse Project] e4 Reporter: Eric Moffatt <emoffatt>
Component: UIAssignee: Project Inbox <e4.ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: 1.0 RC2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Introduce a 'glue' layout modifier none

Description Eric Moffatt CLA 2010-07-05 10:53:26 EDT 
Right now if you resize the window it will first place the Perspetive Switcher onto the second line (where it is *not* left-aligned because the spacer control is still on the first line...).
Comment 1 Eric Moffatt CLA 2010-07-05 11:03:41 EDT 
Created attachment 173439 [details]
Introduce a 'glue' layout modifier


This patch augments the TrimBarLayout to understand a second modifier "glue" that will ensure that the TrimControls to either side of it appear on the same tiled line in the layout.

Note that the layout code is somewhat fragile at the moment in that it won't handle strange conditions such as multiple successive 'glue' modifiers or odd combinations of glue and spacers...
Comment 2 Eric Moffatt CLA 2010-07-05 11:05:21 EDT 
Committed in >20100705. Applied the patch. 

I'll mark this as fixed, we can open a separate defect if we end up in any of the unhandled corners...