Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 318855

Summary:

'Configure' context menu is empty and at wrong location

Product:

[Eclipse Project] e4

Reporter:

Dani Megert <daniel_megert>

Component:

Assignee:

Paul Webster <pwebster>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

bokowski, remy.suen, thatnitind

Version:

1.0

Flags:

remy.suen: review+

Target Milestone:

1.0 RC3

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
allow empty menus to at least look deliberate v01	none
menu contributions in popup menus v01	none

Description Dani Megert

2010-07-05 05:35:12 EDT

I20100701-1105.

1. start new workspace
2. create a Java project
3. context menu > Configure
==> sub-menu is empty.

Comment 1 Paul Webster

2010-07-08 09:59:15 EDT

eclipse.buildId=I20100706-2130
java.fullversion=JRE 1.6.0 IBM J9 2.4 Linux x86-32 jvmxi3260sr8-20100401_55940 (JIT enabled, AOT enabled)
J9VM - 20100401_055940
JIT  - r9_20100401_15339
GC   - 20100308_AA
BootLoader constants: OS=linux, ARCH=x86, WS=gtk, NL=en_US
Command-line arguments:  -os linux -ws gtk -arch x86 -data /opt/pwebster/workspaces/e4


Error
Thu Jul 08 08:02:14 EDT 2010
Plug-in 'org.eclipse.pde.ui' contributed an invalid Menu Extension (Path: 'org.eclipse.ui.projectConfigure' is invalid): org.eclipse.pde.ui.ConvertedProjectWizard

this is being rejected.

PW

Comment 2 Paul Webster

2010-07-13 10:32:45 EDT

Created attachment 174154 [details]
allow empty menus to at least look deliberate v01

Released
PW

Comment 3 Paul Webster

2010-07-13 15:38:40 EDT

Configure is a menuContribution that other projects contribute to ... using popupMenus.

In our 4.0 world, popup menus (all still done using MenuManager and PopupMenuExtender and object contributions)  cannot see the menuContributions like Configure.

This requires some thought.

PW

Comment 4 Paul Webster

2010-07-19 20:13:01 EDT

*** Bug 318845 has been marked as a duplicate of this bug. ***

Comment 5 Paul Webster

2010-07-19 20:13:08 EDT

*** Bug 318846 has been marked as a duplicate of this bug. ***

Comment 6 Paul Webster

2010-07-19 20:15:26 EDT

Created attachment 174691 [details]
menu contributions in popup menus v01

Scan menu contributions in PopupMenuExtender, and insert MenuManager/MRenderedMenus for any MMenus that we find.

PW

Comment 7 Paul Webster

2010-07-19 20:24:30 EDT

Remy?  Boris?

PW

Comment 8 Dani Megert

2010-07-20 02:34:43 EDT

Updated summary since bug 318845 got marked as duplicate of this one. From said bug:

The menu always appears at the top instead of 

Configure >
--- separator ---
Properties
=== END ===

Comment 9 Remy Suen

2010-07-20 08:50:05 EDT

Looks good to me. Confirmed that org.eclipse.ui.menus also works.

<extension point="org.eclipse.ui.menus">
  <menuContribution
      locationURI="popup:org.eclipse.ui.projectConfigure?after=additions">
    <command commandId="org.eclipse.ui.help.aboutAction"/>
  </menuContribution>
</extension>

Comment 10 Paul Webster

2010-07-20 14:17:21 EDT

Released for I20100720-1900
PW

Comment 11 Dani Megert

2010-07-21 05:29:37 EDT

Verified in SDK 4.0 - I20100720-2028.