Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 318711

Summary:

Toolbar items disappear while a dialog is up, major flickering

Product:

[Eclipse Project] e4

Reporter:

Dani Megert <daniel_megert>

Component:

Assignee:

Remy Suen <remy.suen>

Status:

VERIFIED FIXED

QA Contact:

Paul Webster <pwebster>

Severity:

major

Priority:

CC:

bokowski, pwebster, remy.suen, susan

Version:

1.0

Flags:

pwebster: review+

Target Milestone:

1.0 RC2

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
ShellActivationListener patch v1	none

Description Dani Megert

2010-07-02 09:02:51 EDT

SDK 4.0 - I20100701-1105.

When a dialog is opened (e.g. wizard), the toolbar is updated and items get removed. This causes major UI flickering, hurting my eyes while working with Eclipse.

Comment 1 Dani Megert

2010-07-02 09:03:27 EDT

And, of course same when the dialog is closed.

Comment 2 Dani Megert

2010-07-02 09:14:04 EDT

Also happens when using quick views, e.g. Ctrl+O.

Comment 3 Susan McCourt

2010-07-08 10:49:58 EDT

Renaming this bug because I think the problem is much worse than "flickering".  The toolbar becomes mostly empty while a dialog is up.

Comment 4 Remy Suen

2010-07-08 12:13:25 EDT

On today's call we considered the idea of parenting the dialog off of the perspective instead of the window. This is not difficult to change but things get problematic with non-modal dialogs such as the Ctrl+F dialog or the PMD that shows up for jobs. Those will need to be reparented as well or else I think we'd get into a state where selecting the dialog pulls up action sets of the previous perspective.

Comment 5 Remy Suen

2010-07-08 16:23:44 EDT

Parenting the dialog context off of the application's context appears to be working. The tool items are not magically disappearing.

The algorithm of resetting the active child chain still needs to be sorted out with regards to how to correct the chain after a modal/non-modal shell has been closed.

Comment 6 Remy Suen

2010-07-09 08:27:25 EDT

Created attachment 173850 [details]
ShellActivationListener patch v1

This patch changes ShellActivationListener to parent dialog contexts off of the application instead of the window.

Comment 7 Remy Suen

2010-07-09 08:30:12 EDT

Paul, can you take a gander?

Comment 8 Remy Suen

2010-07-09 09:00:01 EDT

<paulweb515> rcjsuen: so that's OK, at least it makes sense
<paulweb515> rcjsuen: I'd only suggest you take the MWindow case statement out of the handleEvent(*) into some processWindow(*) method

Method extracted and delivered.

Comment 9 Dani Megert

2010-07-13 08:38:35 EDT

Verified in SDK 4.0 - I20100712-2029.