Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 318698

Summary: [api] Additional API for supported facets in IProjectFacet
Product: [WebTools] WTP Common Tools Reporter: Kaloyan Raev <kaloyan>
Component: Faceted Project FrameworkAssignee: Konstantin Komissarchik <konstantin>
Status: RESOLVED FIXED QA Contact: Konstantin Komissarchik <konstantin>
Severity: enhancement    
Priority: P3 Keywords: api
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch
none
Patch v2 none

Description Kaloyan Raev CLA 2010-07-02 07:31:02 EDT 
I'd like to have two more methods in the IProjectFacet API that are related to supported facets by an IRuntime: 
  - getSupportedVersions(IRuntime runtime)
  - getSortedSupportedVersions(boolean ascending, IRuntime runtime)
Comment 1 Kaloyan Raev CLA 2010-07-02 07:32:16 EDT 
Created attachment 173290 [details]
patch

Here is a patch that implements these two methods.
Comment 2 Konstantin Komissarchik CLA 2010-07-02 18:34:47 EDT 
Thanks for the patch. I like the idea of adding the proposed api.

You haven't specified, but this doesn't look like a critical adopter issue. I am targeting this to the 2.0 release as the 1.x stream will only carry bug fixes and adopter-critical enhancements.
Comment 3 Konstantin Komissarchik CLA 2010-07-02 18:37:17 EDT 
There has been some work in 2.0 stream that affects the exact structure of the proposed API. See Bug 318765. Will attach a modified patch.
Comment 4 Konstantin Komissarchik CLA 2010-07-02 18:49:24 EDT 
Created attachment 173333 [details]
Patch v2

This patch ports the original patch to the 2.0 code line and adjusts it for API changes in that code line.
Comment 5 Konstantin Komissarchik CLA 2010-07-02 18:50:56 EDT 
Patch released.
Comment 6 Kaloyan Raev CLA 2010-07-06 02:57:15 EDT 
(In reply to comment #2)
> Thanks for the patch. I like the idea of adding the proposed api.
> 
> You haven't specified, but this doesn't look like a critical adopter issue. I
> am targeting this to the 2.0 release as the 1.x stream will only carry bug
> fixes and adopter-critical enhancements.

Not a critical at all. I just found myself using such logic in our adopter's code and thought it may be a good idea to have it in the API. 

Thanks for releasing the patch.