Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 318618

Summary: Use URLImageDescriptor to load images
Product: [Tools] MAT Reporter: Benjamin Muskalla <b.muskalla>
Component: GUIAssignee: Project Inbox <mat.gui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: minor    
Priority: P3 CC: andrew_johnson
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
patch andrew_johnson: iplog+

Description Benjamin Muskalla CLA 2010-07-01 10:46:22 EDT 
Just a minor thing I noticed: MemoryAnalyserPlugin loads images itself from a URL. You can use URLImageDescriptor to save some code and get rid of the error handling.

And btw: missing_image.gif is missing ;-)
Comment 1 Benjamin Muskalla CLA 2010-07-01 10:46:46 EDT 
Created attachment 173223 [details]
patch

Patch
Comment 2 Andrew Johnson CLA 2010-08-12 11:52:50 EDT 
Good idea - thanks.

To follow the Eclipse Legal Process, please can you confirm that you
(a) wrote 100% of the code; 
(b) that you have the right to contribute the code to Eclipse; 
and that it is contributed under the Eclipse Public License.

For part c, the file has already has license header, but I'll add your name as a contributor.
(c) the file header contains the appropriate License header.
Comment 3 Benjamin Muskalla CLA 2010-08-12 11:58:20 EDT 
a) yep
b) yep
c) thanks

But I don't think I need to answer all these things as committer. I think only non-committers need to do that.
Comment 4 Andrew Johnson CLA 2010-08-12 13:04:21 EDT 
I've applied and committed the patch.

I think the committer status is on a project basis, so in the Eclipse legal process poster, figure 1 says "Written 100% by Submitting Committer or Committer on same Project under the supervision of the PMC", figure 3 says "Written 100% by Submitting Contributor (Non-Committer) and Submitted under the terms of the Project License (typically EPL)".