Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 318581

Summary: Use of deprecated org.eclipse.core.runtime.PluginVersionIdentifier
Product: [Tools] CDT Reporter: Petri Tuononen <petri.tuononen>
Component: cdt-build-managedAssignee: Andrew Gvozdev <angvoz.dev>
Status: RESOLVED FIXED QA Contact: Chris Recoskie <recoskie>
Severity: trivial    
Priority: P3 CC: petri.tuononen
Version: 7.0   
Target Milestone: 8.0   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 319850    
Attachments:
Description Flags
Changes references to org.eclipse.core.runtime.PluginVersionIdentifier to org.osgi.framework.Version
angvoz.dev: iplog+
eclipse patch
angvoz.dev: iplog-
final patch angvoz.dev: iplog-

Description Petri Tuononen CLA 2010-07-01 07:17:12 EDT 
Build Identifier: 20100617-1415

References to deprecated org.eclipse.core.runtime.PluginVersionIdentifier could be changed to use org.osgi.framework.Version instead.

Reproducible: Always
Comment 1 Petri Tuononen CLA 2010-07-01 07:19:36 EDT 
Created attachment 173200 [details]
Changes references to org.eclipse.core.runtime.PluginVersionIdentifier to org.osgi.framework.Version

This patch changes all references to PluginVersionIdentifier in CDT to Version.
Comment 2 Andrew Gvozdev CLA 2010-07-02 15:47:24 EDT 
Created attachment 173330 [details]
eclipse patch

This is patch from comment 1 but as eclipse patch
Comment 3 Andrew Gvozdev CLA 2010-07-08 16:55:04 EDT 
Created attachment 173815 [details]
final patch

Increased version for managedbuilder plugins and @since tags added
Comment 4 Andrew Gvozdev CLA 2010-07-08 16:59:43 EDT 
Committed on the HEAD (8.0). Thanks for the patch!
Comment 5 CDT Genie CLA 2010-07-08 17:23:05 EDT 
*** cdt cvs genie on behalf of agvozdev ***
bug 318581: Use of deprecated org.eclipse.core.runtime.PluginVersionIdentifier discontinued.
Patch from Petri Tuononen.

[*] MANIFEST.MF 1.14 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.ui.tests/META-INF/MANIFEST.MF?root=Tools_Project&r1=1.13&r2=1.14

[*] TestFolderInfo.java 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.ui.tests/src/org/eclipse/cdt/managedbuilder/ui/tests/util/TestFolderInfo.java?root=Tools_Project&r1=1.5&r2=1.6
[*] TestProjectType.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.ui.tests/src/org/eclipse/cdt/managedbuilder/ui/tests/util/TestProjectType.java?root=Tools_Project&r1=1.3&r2=1.4
[*] TestConfiguration.java 1.7 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.ui.tests/src/org/eclipse/cdt/managedbuilder/ui/tests/util/TestConfiguration.java?root=Tools_Project&r1=1.6&r2=1.7
[*] TestToolchain.java 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.ui.tests/src/org/eclipse/cdt/managedbuilder/ui/tests/util/TestToolchain.java?root=Tools_Project&r1=1.8&r2=1.9

[*] MANIFEST.MF 1.24 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.ui/META-INF/MANIFEST.MF?root=Tools_Project&r1=1.23&r2=1.24

[*] UpdateManagedProjectManager.java 1.17 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/projectconverter/UpdateManagedProjectManager.java?root=Tools_Project&r1=1.16&r2=1.17

[*] MbsMacroSupplier.java 1.24 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/macros/MbsMacroSupplier.java?root=Tools_Project&r1=1.23&r2=1.24

[*] ManagedBuildManager.java 1.135 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/core/ManagedBuildManager.java?root=Tools_Project&r1=1.134&r2=1.135
[*] IBuildObject.java 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/core/IBuildObject.java?root=Tools_Project&r1=1.8&r2=1.9
[*] IManagedIsToolChainSupported.java 1.3 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/core/IManagedIsToolChainSupported.java?root=Tools_Project&r1=1.2&r2=1.3

[*] MANIFEST.MF 1.23 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/META-INF/MANIFEST.MF?root=Tools_Project&r1=1.22&r2=1.23

[*] MultiConfiguration.java 1.13 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/MultiConfiguration.java?root=Tools_Project&r1=1.12&r2=1.13
[*] TargetPlatform.java 1.11 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/TargetPlatform.java?root=Tools_Project&r1=1.10&r2=1.11
[*] Tool.java 1.100 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/Tool.java?root=Tools_Project&r1=1.99&r2=1.100
[*] BuildObject.java 1.10 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/BuildObject.java?root=Tools_Project&r1=1.9&r2=1.10
[*] ManagedProject.java 1.25 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/ManagedProject.java?root=Tools_Project&r1=1.24&r2=1.25
[*] OptionReference.java 1.35 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/OptionReference.java?root=Tools_Project&r1=1.34&r2=1.35
[*] ResourceConfiguration.java 1.29 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/ResourceConfiguration.java?root=Tools_Project&r1=1.28&r2=1.29
[*] Target.java 1.41 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/Target.java?root=Tools_Project&r1=1.40&r2=1.41
[*] Builder.java 1.42 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/Builder.java?root=Tools_Project&r1=1.41&r2=1.42
[*] ToolChain.java 1.53 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/ToolChain.java?root=Tools_Project&r1=1.52&r2=1.53
[*] OptionCategory.java 1.20 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/OptionCategory.java?root=Tools_Project&r1=1.19&r2=1.20
[*] Option.java 1.48 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/Option.java?root=Tools_Project&r1=1.47&r2=1.48
[*] InputType.java 1.30 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/InputType.java?root=Tools_Project&r1=1.29&r2=1.30
[*] MultiResourceInfo.java 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/MultiResourceInfo.java?root=Tools_Project&r1=1.8&r2=1.9
[*] Configuration.java 1.92 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/Configuration.java?root=Tools_Project&r1=1.91&r2=1.92
[*] ProjectType.java 1.20 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/ProjectType.java?root=Tools_Project&r1=1.19&r2=1.20
[*] ToolReference.java 1.46 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/ToolReference.java?root=Tools_Project&r1=1.45&r2=1.46
[*] OutputType.java 1.14 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/internal/core/OutputType.java?root=Tools_Project&r1=1.13&r2=1.14

[*] TestMacro.java 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core.tests/tests/org/eclipse/cdt/managedbuilder/core/tests/TestMacro.java?root=Tools_Project&r1=1.5&r2=1.6

[*] MANIFEST.MF 1.16 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core.tests/META-INF/MANIFEST.MF?root=Tools_Project&r1=1.15&r2=1.16

[*] IsGnuCygwinToolChainSupported.java 1.12 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.gnu.ui/src/org/eclipse/cdt/managedbuilder/gnu/cygwin/IsGnuCygwinToolChainSupported.java?root=Tools_Project&r1=1.11&r2=1.12

[*] MingwIsToolChainSupported.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.gnu.ui/src/org/eclipse/cdt/managedbuilder/gnu/mingw/MingwIsToolChainSupported.java?root=Tools_Project&r1=1.3&r2=1.4

[*] MANIFEST.MF 1.13 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.gnu.ui/META-INF/MANIFEST.MF?root=Tools_Project&r1=1.12&r2=1.13
Comment 6 Andrew Gvozdev CLA 2010-07-09 20:56:06 EDT 
The fix is causing an exception:

java.lang.ClassCastException: org.osgi.framework.Version cannot be cast to org.eclipse.core.runtime.IStatus
	at org.eclipse.cdt.managedbuilder.core.ManagedBuildManager.getVersionFromIdAndVersion(ManagedBuildManager.java:3198)
	at org.eclipse.cdt.managedbuilder.internal.core.BuildObject.getVersionFromId(BuildObject.java:96)
	at org.eclipse.cdt.managedbuilder.internal.core.Tool.loadFromManifest(Tool.java:673)
	at org.eclipse.cdt.managedbuilder.internal.core.Tool.<init>(Tool.java:189)
	at org.eclipse.cdt.managedbuilder.internal.core.Tool.<init>(Tool.java:232)
	at org.eclipse.cdt.managedbuilder.internal.core.ToolChain.<init>(ToolChain.java:189)
	at org.eclipse.cdt.managedbuilder.internal.core.FolderInfo.<init>(FolderInfo.java:123)
	at org.eclipse.cdt.managedbuilder.internal.core.Configuration.<init>(Configuration.java:233)
Comment 7 Andrew Gvozdev CLA 2010-07-09 22:19:57 EDT 
Fixed.
Comment 8 CDT Genie CLA 2010-07-09 22:23:02 EDT 
*** cdt cvs genie on behalf of agvozdev ***
bug 318581: Use of deprecated org.eclipse.core.runtime.PluginVersionIdentifier

[*] ManagedBuildManager.java 1.136 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/core/ManagedBuildManager.java?root=Tools_Project&r1=1.135&r2=1.136