Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 318559

Summary:	Alignment of columns when doing copy/paste is hardcoded
Product:	[Tools] MAT	Reporter:	Krum Tsvetkov <krum.tsvetkov>
Component:	GUI	Assignee:	Project Inbox <mat.gui-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	andrew_johnson
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows XP
Whiteboard:

Description Krum Tsvetkov

2010-07-01 04:35:19 EDT

While trying to improve the Copy functionality I found some problem - the alignment for the columns is hardcoded - the first column is left justified, and all the rest right justified. This works fine with all "standard" views in MAT, but if I use OQL to select  the address of an object and its value (say for Strings) then the strings are right justified. This however would need a bit more thinking and therefore I opened a separate message for it.

How to reproduce:
1) open the OQL view
2) execute 
SELECT s.@objectAddress, toString(s) FROM java.lang.String s 
3) copy some lines from the result content and paste to a text file

The functionality is implemented in org.eclipse.mat.ui.util.Copy

Comment 1 Andrew Johnson

2010-08-15 17:27:22 EDT

I've got some code to fix this, and to follow reordering of columns in the GUI, 
and to get the dashed line the right length if the alignment of columns is not 
the default.

I'll add it shortly.

Comment 2 Andrew Johnson

2010-08-16 05:57:48 EDT

I'll commit my changes. 
Should the line separator be CR/LF or line.separator ?

Should export as CSV or HTML follow the reordering of table/tree columns? At the moment they do not.

Krum, please try this and see if it does what you want.

Comment 3 Andrew Johnson

2010-09-10 08:31:54 EDT

Before:

s.@objectAddress|                                              toString(s) 
----------------------------------------------------------------------------
649,759,280     |                                           returnOpenType 
649,759,128     | javax.management.openmbean.OpenMBeanOperationInfoSupport 
649,757,024     | javax.management.openmbean.OpenMBeanParameterInfoSupport 
649,712,528     |                                          Non-heap memory 
649,712,472     |                                                 NON_HEAP 
649,712,408     |                                              Heap memory 
649,712,360     |                                                     HEAP 
----------------------------------------------------------------------------

With the fix:

 s.@objectAddress |toString(s)
---------------------------------------------------------------------------
      649,759,280 |returnOpenType
      649,759,128 |javax.management.openmbean.OpenMBeanOperationInfoSupport
      649,757,024 |javax.management.openmbean.OpenMBeanParameterInfoSupport
      649,712,528 |Non-heap memory
      649,712,472 |NON_HEAP
      649,712,408 |Heap memory
---------------------------------------------------------------------------