Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 318506

Summary: Revert button on Property Page is truncated in Japanese
Product: [WebTools] WTP Common Tools Reporter: Eric Peters <ericdp>
Component: Faceted Project FrameworkAssignee: Konstantin Komissarchik <konstantin>
Status: RESOLVED FIXED QA Contact: Konstantin Komissarchik <konstantin>
Severity: normal    
Priority: P3 CC: keith.chong.ca, kitlo
Version: 3.2   
Target Milestone: 3.2.2   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
screen-capture of truncated text on Revert Button
none
Patch none

Description Eric Peters CLA 2010-06-30 13:42:34 EDT
Created attachment 173132 [details]
screen-capture of truncated text on Revert Button

JAX-RS property page extends org.eclipse.jst.common.project.facet.ui.libprov.LibraryFacetPropertyPage and the "Revert" button in Japanese install is truncated as per screen capture. JSF property page likely has same truncation but do not have Japanese install to verify.

To recreate, add JAX-RS facet to Dynamic web project, then bring up the JAX-RS property page.

Action to take: Expand button size, or use shorter translation?
Comment 1 Konstantin Komissarchik CLA 2010-06-30 14:13:46 EDT
It looks to me that the button did expand. By default, the button size is the same as the ok/cancel/apply buttons. I don't read Japanese, so I cannot tell if this is truncated or not.

If this is an issue with translation, that needs to go to the Babel project. I don't know exactly how they handle issues.
Comment 2 Kit Lo CLA 2010-07-15 00:58:36 EDT
This is not a translation problem. WTP is probably hard-coding the width of the button. If you change the label

revertButton = Revert

in

eclipse\plugins\org.eclipse.jst.common.project.facet.ui\org\eclipse\jst\common\project\facet\ui\libprov\LibraryFacetPropertyPage.properties

to something like

revertButton = Revert Revert Revert

you will see the truncation problem. Routing back to WTP for investigation.
Comment 3 Konstantin Komissarchik CLA 2010-07-16 13:51:32 EDT
Created attachment 174522 [details]
Patch

Reproduced the problem. So we don't create this button, but since we change its label, we must also reset its layout data as what's set by JFace only works for the label that code initially sets.
Comment 4 Konstantin Komissarchik CLA 2010-07-16 13:53:28 EDT
Released the changes to fproj 2.0 code stream. Will wait until WTP 3.2.2 stream opens and release there then. Thanks.
Comment 5 Konstantin Komissarchik CLA 2010-08-16 20:21:43 EDT
Released the fix to 3.2.2 and 3.3.0 code streams.
Comment 6 Konstantin Komissarchik CLA 2010-08-16 20:21:58 EDT
Fixed