Bugzilla – Full Text Bug Listing
| Summary: | Many toolbars on top of one another | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Boris Bokowski <bokowski> | ||||||||
| Component: | UI | Assignee: | Project Inbox <e4.ui-inbox> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | emoffatt, remy.suen | ||||||||
| Version: | unspecified | ||||||||||
| Target Milestone: | 1.0 RC2 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Boris Bokowski
Created attachment 173122 [details]
screen shot
That looks a lot scarier than how it looks on XP. Created attachment 173155 [details]
Screenshot depicting the horror in question.
1. Wipe your deltas.xml.
2. Ctrl+3 > JUnit. It should appear in the same stack as the 'Package Explorer'.
3. Ctrl+3 > Switch to the 'Debug' perspective
4. Ctrl+3 > JUnit. It should appear in the bottom stack.
5. Ctrl+3 > Package Explorer It should appear in the same stack as the 'Debug' view in the top.
6. Ctrl+3 > Switch to the 'Java' perspective
7. Activate the 'Package Explorer' view. See that the toolbar is still the 'JUnit' view's toolbar.
8. Activate the 'JUnit' view.
Depending on how squished your stack is, you may see some pretty strange stuff.
Eric, the bug is in LazyStackRenderer's showElementRecursive(MUIElement, List<MUIElement>) method. Around line 234, the toolbar of the view from the other perspective is reparented appropriate to the correct CTabFolder, however, that CTabFolder's prior 'topRight' control is not disposed which explains why there's still a phantom toolbar lying around. Created attachment 173646 [details]
Patch to dispose the existing TopRight control before setting the new one
Committed in >20100707. Applied the patch. |