Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 318393

Summary:	Last of the non-CamelCase
Product:	[Eclipse Project] e4	Reporter:	Paul Webster <pwebster>
Component:	UI	Assignee:	Project Inbox <e4.ui-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	bokowski, emoffatt, john.arthorne, remy.suen, tom.schindl
Version:	1.0
Target Milestone:	1.0 RC2
Hardware:	PC
OS:	All
Whiteboard:

Description Paul Webster

2010-06-29 18:49:22 EDT

There are still a few attributes that don't conform to our pattern.

iconURI, contributionURI, parentID in MenuContributions only, etc.

These should be fixed, but re-generating the code and re-factoring will be a larger commit.

PW

Comment 1 Thomas Schindl

2010-07-05 11:35:47 EDT

I'm a bit indifferent on this. If we want to do it we need to do it today! Can we discuss for a moment on IRC?

Comment 2 Thomas Schindl

2010-07-05 11:38:29 EDT

Boris & John, what do you think. We should react in the next few days (if we want to make the change we should not wait for the e4 call on thursday!).

I'm out for a business trip Tues/Wed but could try to prepare a patch today.

Comment 3 Thomas Schindl

2010-07-05 11:39:31 EDT

... the really bad thing is that we'd break ALL early adopters with this so probably a mail on e4-dev should be sent out.

Comment 4 Thomas Schindl

2010-07-05 11:57:04 EDT

I've identified the following attributes:

The following attributes will be affected by the change:
* UILabel#iconURI
* Contribution#contributionURI
* Input#inputURI
* MenuContribution#parentID
* PartDescriptor#contributionURI

The good thing is that people should able to fix them quite easily with a text editor because we are not changing any containments, ... .

Comment 5 Thomas Schindl

2010-07-05 12:13:51 EDT

We decided on IRC only to change parentID and leave URI because this is at least consistent with how Java uses the term URI (e.g. File.toURI(), ...) and the breaking change is much much smaller

Comment 6 Thomas Schindl

2010-07-05 12:36:00 EDT

released the parentID => parentId change to HEAD

Comment 7 Remy Suen

2010-07-05 12:48:01 EDT

(In reply to comment #6)
> released the parentID => parentId change to HEAD

The failing tests have also just been corrected.

Comment 8 Paul Webster

2010-07-05 14:15:17 EDT

Released update to UIEvents to be consistent.

PW