Bug 318350

Comment 1 Austin Riddle 2010-06-29 12:11:28 EDT

Ah, thanks...will address that.


(In reply to comment #0)
> The bundles currently have 1.4 as their Execution Environnment but use 1.5
> features. We should either correct the EE to be 1.5 if we need the Java 5
> features or downgrade the source to 1.4.

Comment 2 Austin Riddle 2010-06-29 12:44:10 EDT

Hey Benny, 

I can't seem to find any issues after changing my compiler compliance level to 1.4.  Can you give me any explicit examples?

Thanks.


(In reply to comment #0)
> The bundles currently have 1.4 as their Execution Environnment but use 1.5
> features. We should either correct the EE to be 1.5 if we need the Java 5
> features or downgrade the source to 1.4.

Comment 3 Benjamin Muskalla 2010-06-29 12:46:38 EDT

You need an 1.4 JRE to see the issues as they are refer to classes that are not part of the 1.4 rt.jar

Examples:

StringBuilder cannot be resolved to a type	Application.java	/org.eclipse.rap.rwt.visualization.jit.demo/src/org/eclipse/rap/rwt/visualization/jit/demo	line 188
The method nanoTime() is undefined for the type System	Application.java	/org.eclipse.rap.rwt.visualization.jit.demo/src/org/eclipse/rap/rwt/visualization/jit/demo	line 192
ArrayBlockingQueue cannot be resolved to a type	JITWidgetLCA.java	/org.eclipse.rap.rwt.visualization.jit/src/org/eclipse/rap/rwt/visualization/jit/internal	line 114

Comment 4 Austin Riddle 2010-06-29 13:17:37 EDT

(In reply to comment #3)

Thanks Benny, I just committed fixes for those.
Are there any others?

Comment 5 Benjamin Muskalla 2010-06-29 17:44:31 EDT

StringBuilder cannot be resolved to a type	JITGraphLCA.java	/org.eclipse.rap.rwt.visualization.jit/src/org/eclipse/rap/rwt/visualization/jit/internal	line 49
StringBuilder cannot be resolved to a type	JITGraphLCA.java	/org.eclipse.rap.rwt.visualization.jit/src/org/eclipse/rap/rwt/visualization/jit/internal	line 49
The method getCanonicalName() is undefined for the type Class	JITWidgetLCA.java	/org.eclipse.rap.rwt.visualization.jit/src/org/eclipse/rap/rwt/visualization/jit/internal	line 49
The method valueOf(String) in the type Integer is not applicable for the arguments (int)	TreeMapLCA.java	/org.eclipse.rap.rwt.visualization.jit/src/org/eclipse/rap/rwt/visualization/jit/internal/treemapkit	line 28
The method getCanonicalName() is undefined for the type Class	ApplicationWorkbenchAdvisor.java	/org.eclipse.rap.rwt.visualization.jit.demo/src/org/eclipse/rap/rwt/visualization/jit/demo	line 37

I think you should be able to setup API Tooling to warn if you use classes that are not available in your EE.

Comment 6 Austin Riddle 2010-06-30 12:28:43 EDT

(In reply to comment #5)

> I think you should be able to setup API Tooling to warn if you use classes that
> are not available in your EE.

Thanks Ben, I just checked-in what I think are all of the compliance changes, based on my new API tooling settings. ;-)  Thanks for the tip! That was the first time I had ever used it.

Comment 7 Ralf Sternberg 2011-03-10 17:01:29 EST

Austin, these issues seem to be resolved. Can this bug be closed?

Comment 8 Austin Riddle 2011-03-10 17:28:10 EST

The correct project settings have been checked in.