| Summary: | Add "set solib-absolute-prefix" command | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Anna Dushistova <anna.dushistova> | ||||||||
| Component: | cdt-debug-dsf-gdb | Assignee: | Marc Khouzam <marc.khouzam> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | Marc Khouzam <marc.khouzam> | ||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | nobody, pawel.1.piech | ||||||||
| Version: | 7.0 | Flags: | nobody:
review+
|
||||||||
| Target Milestone: | 8.0 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Anna Dushistova
Add MIGDBSetSolibAbsolutePrefix which extends MIGDBSet, and add it to the CommandFactory. Maybe we can fix Bug 229288 at the same time. Created attachment 173253 [details]
patch that adds the command
Created attachment 173551 [details]
Committed fix
Created attachment 173552 [details]
mylyn/context/zip
Mikhail, can you review? Anna, just a note about import preferences: please change the "Number of imports needed for .*" to something bigger than 99. I have 999. You can find that pref in Java->Organize Imports, towards the bottom. This will avoid replacing most imports in CommandFactory with a * The fix I committed simply changed the context type of the new MIGDBSetSolibAbsolutePrefix to be ICommandControlDMContext Looks good. Don't know much about mylyn attachment though. (In reply to comment #8) > Looks good. Don't know much about mylyn attachment though. :-) I just started to use Mylyn and it automatically attached the context. I guess that is a good thing for history... I'll ask Andrew G, he uses Mylyn a lot. *** cdt cvs genie on behalf of mkhouzam *** Bug 318322: Add "set solib-absolute-prefix" command [+] MIGDBSetSolibAbsolutePrefix.java http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MIGDBSetSolibAbsolutePrefix.java?root=Tools_Project&revision=1.1&view=markup [*] CommandFactory.java 1.10 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/CommandFactory.java?root=Tools_Project&r1=1.9&r2=1.10 The since tag for the command factory call is missing. Do you want me to add it? (In reply to comment #11) > The since tag for the command factory call is missing. Do you want me to add it? Sorry about that. For some reason I did not get a compile error. I had to clean my project to finally see it. I've committed a fix. *** cdt cvs genie on behalf of mkhouzam *** Bug 318322: Missing since tag [*] CommandFactory.java 1.11 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/CommandFactory.java?root=Tools_Project&r1=1.10&r2=1.11 |