Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 318322

Summary: Add "set solib-absolute-prefix" command
Product: [Tools] CDT Reporter: Anna Dushistova <anna.dushistova>
Component: cdt-debug-dsf-gdbAssignee: Marc Khouzam <marc.khouzam>
Status: RESOLVED FIXED QA Contact: Marc Khouzam <marc.khouzam>
Severity: normal    
Priority: P3 CC: nobody, pawel.1.piech
Version: 7.0Flags: nobody: review+
Target Milestone: 8.0   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
patch that adds the command
marc.khouzam: iplog+, marc.khouzam: review+
Committed fix
marc.khouzam: iplog-
mylyn/context/zip none

Description Anna Dushistova CLA 2010-06-29 09:47:27 EDT
I'd like to be able to set solib-absolute-prefix via DSF.
Comment 1 Marc Khouzam CLA 2010-07-01 06:54:37 EDT
Add MIGDBSetSolibAbsolutePrefix which extends MIGDBSet, and add it to the CommandFactory.

Maybe we can fix Bug 229288 at the same time.
Comment 2 Anna Dushistova CLA 2010-07-01 14:59:04 EDT
Created attachment 173253 [details]
patch that adds the command
Comment 3 Marc Khouzam CLA 2010-07-06 09:52:20 EDT
Created attachment 173551 [details]
Committed fix
Comment 4 Marc Khouzam CLA 2010-07-06 09:52:21 EDT
Created attachment 173552 [details]
mylyn/context/zip
Comment 5 Marc Khouzam CLA 2010-07-06 09:54:21 EDT
Mikhail, can you review?
Comment 6 Marc Khouzam CLA 2010-07-06 09:55:24 EDT
Anna, just a note about import preferences:
please change the "Number of imports needed for .*" to something bigger than 99.  I have 999.
You can find that pref in Java->Organize Imports, towards the bottom.
This will avoid replacing most imports in CommandFactory with a *
Comment 7 Marc Khouzam CLA 2010-07-06 09:56:42 EDT
The fix I committed simply changed the context type of the new MIGDBSetSolibAbsolutePrefix to be ICommandControlDMContext
Comment 8 Nobody - feel free to take it CLA 2010-07-06 10:00:36 EDT
Looks good. Don't know much about mylyn attachment though.
Comment 9 Marc Khouzam CLA 2010-07-06 10:05:08 EDT
(In reply to comment #8)
> Looks good. Don't know much about mylyn attachment though.

:-)
I just started to use Mylyn and it automatically attached the context.  I guess that is a good thing for history...  I'll ask Andrew G, he uses Mylyn a lot.
Comment 11 Nobody - feel free to take it CLA 2010-07-06 13:28:04 EDT
The since tag for the command factory call is missing. Do you want me to add it?
Comment 12 Marc Khouzam CLA 2010-07-06 14:29:41 EDT
(In reply to comment #11)
> The since tag for the command factory call is missing. Do you want me to add it?

Sorry about that.  For some reason I did not get a compile error.  I had to clean my project to finally see it.  I've committed a fix.