Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 318286

Summary:	Command line metaVar NLS not working
Product:	[Technology] JGit	Reporter:	Robin Rosenberg <robin.rosenberg>
Component:	JGit	Assignee:	Project Inbox <jgit.core-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	caniszczyk, sop
Version:	unspecified
Target Milestone:	1.1
Hardware:	PC
OS:	Linux
Whiteboard:
Bug Depends on:	329136
Bug Blocks:

Description Robin Rosenberg

2010-06-29 05:33:53 EDT

java -jar /home/me/SW/egitcontrib/jgit/org.eclipse.jgit.pgm/target/jgit-cli.jar diff 
fatal: Argument "metaVar_treeish" is required

The NLS mechanism seems to work in other cases

Comment 1 Shawn Pearce

2010-12-01 13:05:28 EST

I think this has already been fixed.

Comment 2 Robin Rosenberg

2010-12-03 00:06:05 EST

diff was just an example. Diff operates without args so it does not
display the message, but here is another

$ ./org.eclipse.jgit.pgm/target/jgit clone
fatal: Argument "metaVar_uriish" is required

$ ./org.eclipse.jgit.pgm/target/jgit rm
fatal: Argument "metaVar_path" is required

and so on

Comment 3 Shawn Pearce

2010-12-03 15:19:16 EST

The problem here is in args4j.  Its formatting the error message without allowing the metaVar property in the @Argument or @Option annotation to be resolved through the property bundle.

We need to upgrade args4j to fix this bug.  We might need to patch this upstream in args4j first too.  :)

Comment 4 Chris Aniszczyk

2010-12-03 15:21:10 EST

2.0.12 is the latest and that's what we have... nothing released since 2009...

Comment 5 Shawn Pearce

2010-12-03 15:34:26 EST

Then we'll have to patch it, and see if upstream will take it.  Or face a fork.

Comment 6 Robin Rosenberg

2011-08-08 17:49:51 EDT

Fixed in I05d4ecf6bd25deec7fb2efbfa61913f4ec4e04e5