| Summary: | EL validation error for quote escaping | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [WebTools] WTP Source Editing | Reporter: | Michael Chervil <michael.krkoska> | ||||
| Component: | jst.jsp | Assignee: | Rakesh <rakes123> | ||||
| Status: | RESOLVED FIXED | QA Contact: | Nitin Dahyabhai <thatnitind> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | mauromol, nsand.dev, pfurbacher, rakes123, sarika.sinha, thatnitind | ||||
| Version: | 3.2 | Flags: | nsand.dev:
review+
|
||||
| Target Milestone: | 3.2.3 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows XP | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Created attachment 175057 [details] patch JSPEL parser failed to take care of escaping of double quotes for strings delimited by single quotes. Reference: http://www.oracle.com/technology/sample_code/tutorials/jsp20/simpleel.html Nick, i have attached changes only in .jjt file , as generating java files with latest javacc is giving compilation errors and i could not get hold of 3.2 version. I didn't risk changing java files manually to remove errors.Do you have javacc version 3.2? Just upgraded to 3.6 (Build id: 20100617-1415) and am encountering the same validation error with the following expression.
${fn:substringAfter(columns[0],'{}')}"
It did not get flagged in 3.5 (Build id: 20100218-1602).
Thanks, Rakesh. Patch looks good to me. Released the changes to HEAD and 3_2_Maintenance. |
Build Identifier: 20100617-1415 These valid EL expressions are being reported as errors: ${'\"'} ${fn:replace(name,'\"','')} The detection of quote escaping seems to be broken. In Eclipse 3.5.1 I could classify this as warning by setting the validation option "EL syntax problem" to "Warning". This doesn't work in Eclipse 3.6. anymore. Some similar bugs were already fixed: 151065, 150794 and lots of duplicates. See also: http://www.eclipse.org/forums/index.php?t=msg&goto=543372 Reproducible: Always