Bugzilla – Full Text Bug Listing
| Summary: | Javadoc does not render properly with WebKitGTK | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] JDT | Reporter: | Grant Gayed <grant_gayed> | ||||
| Component: | UI | Assignee: | Markus Keller <markus.kell.r> | ||||
| Status: | CLOSED DUPLICATE | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | daniel_megert, deepakazad, markus.kell.r | ||||
| Version: | 3.6 | Flags: | daniel_megert:
review+
|
||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Linux-GTK | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Grant Gayed
We can't omit the declarations, since that would e.g. break default Ubuntu installs with their white-on-black tooltips. But we could replace them with values from SWT.COLOR_INFO_FOREGROUND for WebKit. Do you know if it's possible to change the tooltip fg/bg colors on Mac OS X? WebKit could have the same problem there. If I got that right, WebKitGTK is already officially supported in 3.6 (but it's not the default there), so I guess this should also be backported to 3.6.1, right? I'll look at this together with bug 313530. I don't believe there's a way to change these colours on OS X, they're not in the System Preferences or in the "defaults" command line app. Yes, WebKitGTK is supported (but not default) in 3.6, so a 3.6.1 fix would be ideal since this shows itself readily in eclipse, thanks! To update, WebKitGTK is now the default Browser renderer in the 3.7 stream, so this will now appear readily in integration builds as of yesterday's. Created attachment 175226 [details]
Fix
Fix replaces InfoText with the color from SWT.COLOR_INFO_FOREGROUND. The implementation makes sure the color is updated when the OS Settings changed.
The fix also fixes another issue with wrong colors in Java source hovers. When the hover bg color has too little contrast w.r.t. the editor text fg color, we fall back to using the editor bg color. The fallback didn't work reliably when the editor bg color is the system default color. Committed to HEAD. Dani, can you please review for 3.6.1? Note that the fix requires bug 313530. > The fallback didn't work reliably when
>the editor bg color is the system default color.
This part of the patch is good for 3.6.1.
For the other part I have another idea which I'd like to discuss.
In HEAD, I've reverted the changes in JavadocHover, JavadocView, and AbstractJavaCompletionProposal. HTMLPrinter#appendStyleSheet(..) now takes care of replacing InfoText and InfoBackground with static colors. => 3.6.1 only needs changes in HTMLPrinter and SourceViewerInformationControl. The latest fix is not yet 100% complete, see bug 321581. > The latest fix is not yet 100% complete, see bug 321581. Not a big deal and has always been like that, so I don't think we should backport bug 321581 to 3.6.1. >Not a big deal and has always been like that, so I don't think we should >backport bug 321581 to 3.6.1. If we say that hot update is important enough to backport then the backport must be correct and hence bug 321581 is also important enough to be backported. (In reply to comment #10) The question is whether the system is usable after the settings have been changed. Javadoc hovers are not usable any more until you restart Eclipse, that's what that needs to be fixed. Background of the hint text is minor and corrects itself, that's why this should only be backported if trivial. (In reply to comment #7) > => 3.6.1 only needs changes in HTMLPrinter and SourceViewerInformationControl. And in JavaEditorAppearanceConfigurationBlock, see bug 313943. (In reply to comment #11) > (In reply to comment #10) > The question is whether the system is usable after the settings have been > changed. Javadoc hovers are not usable any more until you restart Eclipse, > that's what that needs to be fixed. Good point. > Background of the hint text is minor and > corrects itself, that's why this should only be backported if trivial. Agreed! > > > (In reply to comment #7) > > => 3.6.1 only needs changes in HTMLPrinter and SourceViewerInformationControl. > And in JavaEditorAppearanceConfigurationBlock, see bug 313943. I suggest you open a new bug for 3.6.1 with a patch. Will be fixed in 3.6.1 with the fix for bug 313530. *** This bug has been marked as a duplicate of bug 313530 *** +1 for 3.6.1 RC2. |