Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 318236

Summary: [CSS] WindowMargins and CTabRendering not applied without a theme
Product: [Eclipse Project] e4 Reporter: Thomas Schindl <tom.schindl>
Component: UIAssignee: Project Inbox <e4.ui-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: gheorghe, yves.yang
Version: 0.9   
Target Milestone: 1.0 RC1   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:
Attachments:
Description Flags
patch
none
patch none

Description Thomas Schindl CLA 2010-06-28 15:51:00 EDT 
We still have a system in place for very small applications where creating a theme is overhead. Applying the margins and the CTabRendering is not working in this case. We are also leaking the CSSEngineImpl through our IThemeEngine-Service which is not really optimal (Susan already added a comment when she added the code).
Comment 1 Thomas Schindl CLA 2010-06-28 15:56:09 EDT 
One can easily test this with the Photo-Demo which is not using our themeing system to apply CSS styling.
Comment 2 Thomas Schindl CLA 2010-06-28 15:57:21 EDT 
Created attachment 172947 [details]
patch

This patches removes the leaking of the CSSEngine and fixes the margins problem - I haven't found out yet why the CTabRendering is not working
Comment 3 Thomas Schindl CLA 2010-06-28 16:06:47 EDT 
Created attachment 172948 [details]
patch

fix for the CTabRendering
Comment 4 Thomas Schindl CLA 2010-06-28 16:09:16 EDT 
released changes to HEAD
Comment 5 Thomas Schindl CLA 2010-06-28 16:09:51 EDT 
Yves, please check if my changes to your XWT-Code as correct