Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 318214

Summary:

[remote launch] Unify Basic remote launch with Advanced remote launch

Product:

[Tools] CDT

Reporter:

Marc Khouzam <marc.khouzam>

Component:

cdt-debug-dsf-gdb

Assignee:

Marc Khouzam <marc.khouzam>

Status:

RESOLVED FIXED

QA Contact:

Marc Khouzam <marc.khouzam>

Severity:

normal

Priority:

CC:

anna.dushistova, mober.at+eclipse, pawel.1.piech, ted

Version:

7.0

Flags:

marc.khouzam: review? (pawel.1.piech)

Target Milestone:

8.0

Hardware:

OS:

Linux

Whiteboard:

Bug Depends on:

314659

Bug Blocks:

Attachments:

Description	Flags
Fix	marc.khouzam: iplog-

Description Marc Khouzam

2010-06-28 13:10:51 EDT

A part of Bug 314659, DSF-GDB will support an Advanced remote launch which uses RSE to start gdbserver and potentially upload the application to the target. This advance launch is dependent on having RSE available. This launch is also an optional CDT feature. Also, this launch creates a fourth launch configuration type called "C/C++ Remote Application".

Currently, DSF-GDB provides with a basic remote launch which requires the user to manually start gdbserver and upload the application to the target. This launch is a delegate assigned the "C/C++ Application" launch config type.

Here is what I'd like to do:
1- Move the launch config type "C/C++ Remote Application" to main CDT
2- Move DSF-GDB's basic remote launch to that launch config type
3- If the advanced remote launch is installed, it should be the default delegate for that launch config type; if it is not installed, the basic remote launch should be the default.
4- If the advanced remote launch is installed later on, it should become the default, unless the user manually decides to use the basic as the default

What this should do for a normal user is that when using plain CDT, they would see a "C/C++ Remote Application" that would require them to start gdbserver manually. If they install the advanced remote launch (and RSE) they would continue to use "C/C++ Remote Application", but it would be slightly enhanced to automatically start gdbserver.

This seems pretty simple. The problem I'm worried about is having the Advanced Remote launch but no RSE. This seems to make the launch config not work without a clear indication to the user.

Comment 1 Marc Khouzam

2010-06-28 13:41:16 EDT

Another potential complication is the Run... aspect of this launch config type.  Without RSE and the advanced remote launch, it does not make much sense to offer this "C/C++ Remote Application" in Run mode because it won't do anything.

But I think this will work out because the launch config type should not be shown for Run mode unless we have a delegate for Run mode, which we will keep in the Advance remote launch feature.  Therefore, I'm counting on the fact that this new launch config will only be seen in Run mode if the user installs the advance launch feature.

Comment 2 Marc Khouzam

2010-07-23 14:05:11 EDT

Created attachment 175089 [details]
Fix

This patch does exactly what I had suggested:

1- Move the launch config type "C/C++ Remote Application" to main CDT
2- Move DSF-GDB's basic remote launch to that launch config type
3- If the advanced remote launch is installed, it should be the default delegate for that launch config type; if it is not installed, the basic remote launch should be the default.
4- If the advanced remote launch is installed later on, it should become the default, unless the user manually decides to use the basic as the default

Also, I confirmed that the new launch config type is not shown for Run mode unless we have the advanced delegate installed.

Comment 3 Marc Khouzam

2010-07-23 14:07:04 EDT

Committed to HEAD

Comment 4 Marc Khouzam

2010-07-23 14:08:50 EDT

Pawel, can you review?

Comment 5 Marc Khouzam

2010-07-23 14:09:22 EDT

Anna, could you make sure it is still ok for you?  I made some changes to launch.remote

Comment 6 CDT Genie

2010-07-23 14:23:04 EDT

*** cdt cvs genie on behalf of mkhouzam ***
Bug 318214: Unify Basic remote launch with Advanced remote launch

[*] plugin.xml 1.249 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/plugin.xml?root=Tools_Project&r1=1.248&r2=1.249

[*] ImportExecutablePageTwo.java 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/ui/importexecutable/ImportExecutablePageTwo.java?root=Tools_Project&r1=1.8&r2=1.9

[*] plugin.properties 1.27 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.core/plugin.properties?root=Tools_Project&r1=1.26&r2=1.27
[*] plugin.xml 1.49 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.core/plugin.xml?root=Tools_Project&r1=1.48&r2=1.49

[*] MANIFEST.MF 1.28 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.core/META-INF/MANIFEST.MF?root=Tools_Project&r1=1.27&r2=1.28

[*] CDebugCorePlugin.java 1.39 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/core/CDebugCorePlugin.java?root=Tools_Project&r1=1.38&r2=1.39
[*] ICDTLaunchConfigurationConstants.java 1.33 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.debug.core/src/org/eclipse/cdt/debug/core/ICDTLaunchConfigurationConstants.java?root=Tools_Project&r1=1.32&r2=1.33

[*] plugin.xml 1.39 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb.ui/plugin.xml?root=Tools_Project&r1=1.38&r2=1.39

[*] plugin.properties 1.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/plugin.properties?root=Tools_Project&r1=1.4&r2=1.5
[*] plugin.xml 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/dsf-gdb/org.eclipse.cdt.dsf.gdb/plugin.xml?root=Tools_Project&r1=1.5&r2=1.6

[*] Activator.java 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/cross/org.eclipse.cdt.launch.remote/src/org/eclipse/cdt/internal/launch/remote/Activator.java?root=Tools_Project&r1=1.3&r2=1.4

[*] plugin.properties 1.5 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/cross/org.eclipse.cdt.launch.remote/plugin.properties?root=Tools_Project&r1=1.4&r2=1.5
[*] plugin.xml 1.4 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/cross/org.eclipse.cdt.launch.remote/plugin.xml?root=Tools_Project&r1=1.3&r2=1.4

[-] RemoteLaunchConfigurationTabGroup.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/cross/org.eclipse.cdt.launch.remote/src/org/eclipse/cdt/launch/remote/tabs/RemoteLaunchConfigurationTabGroup.java?root=Tools_Project&view=markup

Comment 7 Anna Dushistova

2010-07-25 07:08:24 EDT

(In reply to comment #5)
> Anna, could you make sure it is still ok for you?  I made some changes to
> launch.remote

Marc, still fine for me.