Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 318176

Summary: Domainmodel Example has bogus ScopeProvider implementation
Product: [Modeling] TMF Reporter: Sebastian Zarnekow <sebastian.zarnekow>
Component: XtextAssignee: Project Inbox <tmf.xtext-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: jan, sven.efftinge
Version: 1.0.0Flags: sebastian.zarnekow: helios+
Target Milestone: SR1   
Hardware: PC   
OS: Mac OS X - Carbon (unsup.)   
Whiteboard:

Description Sebastian Zarnekow CLA 2010-06-28 09:26:32 EDT 

    


    


      



        
          Comment 1
        

        
          Jan Koehnlein CLA

        

        
        

        
          2010-06-28 14:36:44 EDT
        

      






Into the bargain, 

- the auto edit strategy is not registered
- the generator does not check if resources have "dmodel" file extension (bad style, could cause performance issues)
- the template does not create anything from operations
- the enum literals in the grammar could be derived (default)
- parentheses in the grammar is inconsistent: QualifiedName ('.*')?;
- grammar is generated with backtracking (not necessary, is it?)
- it is kind of strange to have no "mapsto <JavaType>" as we have to redefine datatypes for all needed JavaTypes in order to generate error free code

    


    


      



        
          Comment 2
        

        
          Sven Efftinge CLA

        

        
        

        
          2010-08-10 10:47:37 EDT
        

      






Fixed the scope provider

- the auto edit strategy is not registered

Fixed

- the generator does not check if resources have "dmodel" file extension (bad
style, could cause performance issues)

Don't consider this bad style in general. The signature of the generator goes against the type Entity
which is checked.

- the template does not create anything from operations
It's just an example.

- the enum literals in the grammar could be derived (default)
Fixed.

- parentheses in the grammar is inconsistent: QualifiedName ('.*')?;
Fixed.

- grammar is generated with backtracking (not necessary, is it?)
Fixed.

- it is kind of strange to have no "mapsto <JavaType>" as we have to redefine
datatypes for all needed JavaTypes in order to generate error free cod

Opened a new bugzilla https://bugs.eclipse.org/bugs/show_bug.cgi?id=322240

    


    


      



        
          Comment 3
        

        
          Karsten Thoms CLA

        

        
        

        
          2017-09-19 15:52:17 EDT
        

      






Closing bug which were set to RESOLVED before Eclipse Neon.0.