Bug 318153

Comment 1 Ishan Jayawardena 2010-06-28 06:04:29 EDT

Created attachment 172882 [details]
patch (part 1 of 2) process instance cleanup configuration

process instance cleanup configuration support for deployment descriptor added. This patch(part 1 of 2) includes the changes required for org.eclipse.bpel.apache.ode.deploy.model package.

Comment 2 Ishan Jayawardena 2010-06-28 06:06:03 EDT

Created attachment 172883 [details]
patch (part 2 of 2) for process instance cleanup configuration

process instance cleanup configuration support for deployment descriptor added. This patch(part 2 of 2) includes the changes required for org.eclipse.bpel.apache.ode.deploy.ui package.

Comment 3 grid.qian 2010-09-27 04:54:37 EDT

(In reply to comment #0)
> Current deploy.xml editor doesn't support process instance cleanup
> configuration and newly introduced WSO2 BPS specific process instance deletion
> scheduled task configuration. We need to add that support to deploy.xml editor.

Hi Ishan,

What is bpel process instance cleanup support£¿Please give a a detail.

Comment 4 Ishan Jayawardena 2010-09-27 05:49:26 EDT

(In reply to comment #3)
> (In reply to comment #0)
> > Current deploy.xml editor doesn't support process instance cleanup
> > configuration and newly introduced WSO2 BPS specific process instance deletion
> > scheduled task configuration. We need to add that support to deploy.xml editor.
> 
> Hi Ishan,
> 
> What is bpel process instance cleanup support£¿Please give a a detail.

Hi,
It's mentioned in the ODE's Instance Data Cleanup section[0] and we are trying to implement that for ODE.


[0] http://ode.apache.org/instance-data-cleanup.html

Comment 5 Ishan Jayawardena 2010-09-27 06:12:44 EDT

(In reply to comment #3)
> (In reply to comment #0)
> > Current deploy.xml editor doesn't support process instance cleanup
> > configuration and newly introduced WSO2 BPS specific process instance deletion
> > scheduled task configuration. We need to add that support to deploy.xml editor.
> 
> Hi Ishan,
> 
> What is bpel process instance cleanup support£¿Please give a a detail.

Hi,
It's mentioned in the ODE's Instance Data Cleanup section[0] and we are trying to implement that for ODE.


[0] http://ode.apache.org/instance-data-cleanup.html

Comment 6 grid.qian 2010-12-01 01:26:34 EST

Look into your patch and do some tests. Based on the link that you said, as if there are some defects:
1 use the ode editor, we can create a cleanup like this:
    <cleanup on="success">
      <category>instance</category>
      <category>messages</category>
      <category>correlations</category>
      <category>events</category>
      <category>all</category>
    </cleanup>

I think if the category is 'all' means we choose all of instance, messages, correlations, events and messages, right? 


2 "5. an invalid configuration; the instance category should accompany the variable and correlations categories"
so we should make user can't create a cleanup like this:
        <cleanup on="failure">
                <category>instance</category>
        </cleanup>


I don't know more about ODE, so what's your ideas? Could you commit a improved patch? If you are busy, I could do the improvement based on the existing patches.
But I want to know beside 2.(instance), do you know if the ode has other limits for cleanup?

Comment 7 grid.qian 2010-12-01 02:24:43 EST

And another problem is:
as if all the deploy.xml in eclipse workspace use a same cleanup class, right?
in my workspace, I have several bpel projects, if open these deploy.xmls, and set the cleanup for them, I found they will do influence each other. I think it cause by your using a singleton pattern for Cleanup class, right?



> Look into your patch and do some tests. Based on the link that you said, as if
> there are some defects:
> 1 use the ode editor, we can create a cleanup like this:
>     <cleanup on="success">
>       <category>instance</category>
>       <category>messages</category>
>       <category>correlations</category>
>       <category>events</category>
>       <category>all</category>
>     </cleanup>
> 
> I think if the category is 'all' means we choose all of instance, messages,
> correlations, events and messages, right? 
> 
> 
> 2 "5. an invalid configuration; the instance category should accompany the
> variable and correlations categories"
> so we should make user can't create a cleanup like this:
>         <cleanup on="failure">
>                 <category>instance</category>
>         </cleanup>
> 
> 
> I don't know more about ODE, so what's your ideas? Could you commit a improved
> patch? If you are busy, I could do the improvement based on the existing
> patches.
> But I want to know beside 2.(instance), do you know if the ode has other limits
> for cleanup?

Comment 8 Ishan Jayawardena 2011-02-23 02:50:28 EST

Hi qian,
Sorry about being this late to reply.
(In reply to comment #6)
> Look into your patch and do some tests. Based on the link that you said, as if
> there are some defects:
> 1 use the ode editor, we can create a cleanup like this:
>     <cleanup on="success">
>       <category>instance</category>
>       <category>messages</category>
>       <category>correlations</category>
>       <category>events</category>
>       <category>all</category>
>     </cleanup>
> 
> I think if the category is 'all' means we choose all of instance, messages,
> correlations, events and messages, right? 
> 
> 
Yes. it is.

> 2 "5. an invalid configuration; the instance category should accompany the
> variable and correlations categories"
> so we should make user can't create a cleanup like this:
>         <cleanup on="failure">
>                 <category>instance</category>
>         </cleanup>
> 
> 
> I don't know more about ODE, so what's your ideas? Could you commit a improved
> patch? If you are busy, I could do the improvement based on the existing
> patches.
Sure. If you can do that, it would be great! These days, um a bit short of time. 
I did not consider this possibility. Thank you for highlighting it. :)

> But I want to know beside 2.(instance), do you know if the ode has other limits
> for cleanup?
Right now there's nothing that I can remember or know of. Need to look into the details. There may be other limitations too. If you find something interesting, please share it here.