Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 318142

Summary:

AssertionError in AcceleoSourceContent.getChildrenCandidate

Product:

[Modeling] Acceleo

Reporter:

Ed Willink <ed>

Component:

Core

Assignee:

Project Inbox <acceleo-inbox>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

laurent.goubet, mariot.chauvin

Version:

3.0.0

Keywords:

contributed

Target Milestone:

---

Hardware:

OS:

Windows Vista

Whiteboard:

Attachments:

Description	Flags
Patch	laurent.goubet: iplog+

Description Ed Willink

2010-06-28 03:41:34 EDT

I am getting the following error almost every time I click in the Package Explorer.

java.lang.AssertionError
	at org.eclipse.acceleo.internal.ide.ui.editors.template.AcceleoSourceContent.getChildrenCandidate(AcceleoSourceContent.java:1195)
	at org.eclipse.acceleo.internal.ide.ui.editors.template.AcceleoSourceContent.getResolvedASTNode(AcceleoSourceContent.java:1167)
	at org.eclipse.acceleo.internal.ide.ui.editors.template.utils.OpenDeclarationUtils.findDeclaration(OpenDeclarationUtils.java:774)
	at org.eclipse.acceleo.internal.ide.ui.editors.template.AcceleoEditor.findOccurrences(AcceleoEditor.java:739)
	at org.eclipse.acceleo.internal.ide.ui.editors.template.AcceleoEditor.access$0(AcceleoEditor.java:735)
	at org.eclipse.acceleo.internal.ide.ui.editors.template.AcceleoEditor$3.selectionChanged(AcceleoEditor.java:703)
	at org.eclipse.ui.internal.AbstractSelectionService.firePostSelection(AbstractSelectionService.java:179)
	at org.eclipse.ui.internal.AbstractSelectionService$2.selectionChanged(AbstractSelectionService.java:71)
	at org.eclipse.jface.text.TextViewer.firePostSelectionChanged(TextViewer.java:2745)
	at org.eclipse.jface.text.TextViewer.firePostSelectionChanged(TextViewer.java:2693)
	at org.eclipse.jface.text.TextViewer$5.run(TextViewer.java:2672)
	at org.eclipse.swt.widgets.Display.runTimer(Display.java:4167)

Comment 1 Laurent Goubet

2010-06-28 04:08:38 EDT

Seems to be caused by a "little too eager" listener. FIX commited on HEAD. Stéphane, could you check whether we can reduce the scope of the events we listen to to the current editor instead of the whole workspace page?

Comment 2 Stephane Begaudeau

2010-06-28 05:50:20 EDT

Created attachment 172879 [details]
Patch

This patch will reduce the scope of the event to the current editor. This patch will also correct a NPE found if someone used the findOccurrences mechanism quickly enough when creating a mtl file while Eclipse is launching, just before that this mtl file would be compiled, its output folder could be null.

Comment 3 Laurent Goubet

2010-06-30 09:18:19 EDT

Thanks Stéphane, this has been contributed on HEAD and maintenance.

Comment 4 Ed Willink

2010-07-01 05:20:51 EDT

Working with R3_0_0_maintenance:

This is a big improvement: no more pop-ups, but the console window is still filling up.

Comment 5 Laurent Goubet

2010-07-01 05:34:46 EDT

None of these changes were on maintenance until now, forgot to commit yesterday :p.

This should now be fixed, could you verify?

Comment 6 Laurent Goubet

2010-07-30 03:54:58 EDT

Should be present in the next integration build (which itself should be available later today).