Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 318106

Summary:	Refactor menu throws exception when closed project is selected
Product:	[Tools] PTP	Reporter:	Jeffrey Overbey <com-eclipse-dot-org>
Component:	Photran.For Internal Use	Assignee:	Jeffrey Overbey <com-eclipse-dot-org>
Status:	RESOLVED FIXED	QA Contact:
Severity:	minor
Priority:	P3
Version:	6.0
Target Milestone:	6.0.1
Hardware:	PC
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description Jeffrey Overbey

2010-06-26 22:32:27 EDT

When a closed project is selected and the Refactor menu is clicked, a ResourceException is thrown:

org.eclipse.core.internal.resources.ResourceException: Resource '/MoreBugs' is not open.
	at org.eclipse.core.internal.resources.Project.checkAccessible(Project.java:137)
	at org.eclipse.core.internal.resources.Container.members(Container.java:265)
	at org.eclipse.core.internal.resources.Container.members(Container.java:248)
	at org.eclipse.rephraserengine.ui.WorkbenchSelectionInfo.findAllFilesIn(WorkbenchSelectionInfo.java:209)
	at org.eclipse.rephraserengine.ui.WorkbenchSelectionInfo.findAllFilesIn(WorkbenchSelectionInfo.java:189)
	at org.eclipse.rephraserengine.ui.WorkbenchSelectionInfo.<init>(WorkbenchSelectionInfo.java:132)
	at org.eclipse.rephraserengine.ui.WorkbenchSelectionInfo.<init>(WorkbenchSelectionInfo.java:88)
	at org.eclipse.rephraserengine.ui.menus.RefactorMenu.processConfigElt(RefactorMenu.java:124)
	at org.eclipse.rephraserengine.ui.menus.RefactorMenu.loadRefactoringsFrom(RefactorMenu.java:107)
	at org.eclipse.rephraserengine.ui.menus.RefactorMenu.loadRefactoringsFromExtensionPoint(RefactorMenu.java:96)
	at org.eclipse.rephraserengine.ui.menus.RefactorMenu.getContributionItems(RefactorMenu.java:72)
	at org.eclipse.ui.actions.CompoundContributionItem.getContributionItemsToFill(CompoundContributionItem.java:95)
	at org.eclipse.ui.actions.CompoundContributionItem.fill(CompoundContributionItem.java:70)
	at org.eclipse.ui.internal.menus.DynamicMenuContributionItem.fill(DynamicMenuContributionItem.java:125)
	at org.eclipse.jface.action.MenuManager.doItemFill(MenuManager.java:737)
	at org.eclipse.jface.action.MenuManager.update(MenuManager.java:818)
	at org.eclipse.jface.action.MenuManager.handleAboutToShow(MenuManager.java:470)
	at org.eclipse.jface.action.MenuManager.access$1(MenuManager.java:465)
	at org.eclipse.jface.action.MenuManager$2.menuShown(MenuManager.java:491)
	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:241)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:3776)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1367)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1390)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1371)
	at org.eclipse.swt.widgets.Menu.menuWillOpen(Menu.java:689)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:5030)
	at org.eclipse.swt.internal.cocoa.OS.objc_msgSendSuper(Native Method)
	at org.eclipse.swt.widgets.Display.applicationNextEventMatchingMask(Display.java:4483)
	at org.eclipse.swt.widgets.Display.applicationProc(Display.java:4739)
	at org.eclipse.swt.internal.cocoa.OS.objc_msgSend(Native Method)
	at org.eclipse.swt.internal.cocoa.NSApplication.nextEventMatchingMask(NSApplication.java:85)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3271)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2629)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2593)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2427)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:670)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:663)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:115)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:369)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:592)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:619)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:574)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1407)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1383)

Comment 1 Jeffrey Overbey

2010-06-26 23:02:48 EDT

Committed fix to WorkbenchSelectionInfo.java in ptp_4_1 and HEAD.