Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 318063

Summary:	[API] [cdt.managedbuilder.core] RFE: Request ProjectCreatedActions class remove @noinstantiate restriction
Product:	[Tools] CDT	Reporter:	Jeff Johnston <jjohnstn>
Component:	cdt-build-managed	Assignee:	Project Inbox <cdt-build-managed-inbox>
Status:	ASSIGNED ---	QA Contact:	Jonah Graham <jonah>
Severity:	normal
Priority:	P3
Version:	7.0
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:
Bug Depends on:	336377
Bug Blocks:	314342

Description Jeff Johnston

2010-06-25 19:32:20 EDT

The Autotools project uses ProjectCreatedActions to create a new Autotools project from the New C Project wizard.  The class is public but has been marked noinstatiate which means that an API violation has occurred.  The NewAutotoolsProject code which uses the class is based on the CDT NewManagedProject code.

If there is no particular reason for the @noinstantiate, this is a request to remove the restriction or to provide a suitable API-compliant alternative.

Comment 1 Andrew Gvozdev

2010-09-24 16:47:55 EDT

I took a look at ProjectCreatedActions and I do not think it is sufficiently well defined to deserve to be an API. I think there should be a set of well defined methods to create managed build project in cdt.managedbuilder.core and it should be used by the wizards CDTCommonProjectWizard etc. and by template engine processes including NewAutotoolsProject. I took a shot to define one but CDTCommonProjectWizard much resists to any API so more time investment is necessary. 

So I think for now @noinstantiate should stay until the better API is developed. That is a signal that it is not a stable interface. You still can use it in your product. You can suppress the warning or disregard it. What I can do is to add as a comment a reference to this bug, so the developers would be more cautious not to change the interface.

Comment 2 Andrew Gvozdev

2010-09-29 16:12:42 EDT

Returning to the pool.

Comment 3 CDT Genie

2010-09-29 16:23:06 EDT

*** cdt cvs genie on behalf of agvozdev ***
bug 318063: Note about ISVs in comment.

[*] ProjectCreatedActions.java 1.6 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/all/org.eclipse.cdt.managedbuilder.core/src/org/eclipse/cdt/managedbuilder/templateengine/ProjectCreatedActions.java?root=Tools_Project&r1=1.5&r2=1.6

Comment 4 Andrew Gvozdev

2011-02-04 13:08:17 EST

(In reply to comment #1)
> I took a look at ProjectCreatedActions and I do not think it is sufficiently
> well defined to deserve to be an API. I think there should be a set of well
> defined methods to create managed build project in cdt.managedbuilder.core and
> it should be used by the wizards CDTCommonProjectWizard etc. and by template
> engine processes including NewAutotoolsProject.
It should be probably along the lines of bug 336377.