Bugzilla – Full Text Bug Listing
| Summary: | Restore from local history dialog does not allow selecting files to restore, throws exception in Error Log | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Eric Rizzo <eclipse-bugs> |
| Component: | Compare | Assignee: | Platform-Compare-Inbox <platform-compare-inbox> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | major | ||
| Priority: | P3 | CC: | eclipse-bugs, eclipse.felipe, Silenio_Quarti, skovatch, Szymon.Brandys, tomasz.zarna |
| Version: | 3.6 | ||
| Target Milestone: | --- | ||
| Hardware: | Macintosh | ||
| OS: | Mac OS X | ||
| Whiteboard: | stalebug | ||
|
Description
Eric Rizzo
Eric I'm afraid you're right. This is a Mac specific issue, which is easily reproducible on Eclipse 3.6 (I20100608-0911). What's interesting about this is that in 3.6M7 the situation was even worse: following your steps I was able to hang Eclipse which after a while exited. The reason it does *not* happen on Windows: org.eclipse.compare.internal.AddFromHistoryDialog.fEditionTree's selection listener is not called when selecting a file to restore. This is expected since fEditionTree (top right) displays versions of a file selected in fMemberTable (top left). I guess there was a fix in SWT sometime between 3.6M7 and 3.6 which changed the behavior described above: it did fix the hanging issue, but introduced the exception we're seeing now. Felipe, could you please comment on that? Since it's confirmed reproducible, I wonder if the severity should be bumped to CRITICAL or BLOCKER. This is a major loss of functionality for Mac users. (In reply to comment #2) > Since it's confirmed reproducible, I wonder if the severity should be bumped to > CRITICAL or BLOCKER. This is a major loss of functionality for Mac users. "major" is perfect, take a look at https://bugs.eclipse.org/bugs/page.cgi?id=fields.html#bug_severity. (In reply to comment #1) > I guess there was a fix in SWT sometime between 3.6M7 and 3.6 which changed the > behavior described above: it did fix the hanging issue, but introduced the > exception we're seeing now. Felipe, could you please comment on that? Do you have the bug number for this change ? No, it's a guess based on what I observed in comment 1. The change was for bug 308844. Exceptions thrown while handling a click or double-click on a Tree or Table would hang the app, but now we're able to let any Java exception propagate back to the loop. However, that's not the real fix. Opening a window in response to a MouseDoubleClick event (or in this case, I guess, Selection) on a Tree confuses Cocoa's mouse tracking. I'm looking at double-click handling again for 3.6.1, but I'll look into the Selection events too since it will be related. (In reply to comment #6) > I'm looking at double-click handling again for 3.6.1, > but I'll look into the Selection events too since it will be related. That's good news, is there a bug for it? I could mark this one as blocked then. (In reply to comment #7) > (In reply to comment #6) > > I'm looking at double-click handling again for 3.6.1, > > but I'll look into the Selection events too since it will be related. > > That's good news, is there a bug for it? I could mark this one as blocked then. Bug 313208 is tracking this. It may not look like it from the description, but that's the one. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |