Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 318052

Summary: [remote launch] Properties are not saved/used
Product: [Tools] CDT Reporter: Anna Dushistova <anna.dushistova>
Component: cdt-debugAssignee: Ted Williams <ted>
Status: RESOLVED FIXED QA Contact: Ken Ryall <ken.ryall>
Severity: normal    
Priority: P3 CC: cdtdoug, marc.khouzam, mober.at+eclipse, pawel.1.piech, ted
Version: 7.0   
Target Milestone: 8.0   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
patch that enables saving
none
same patch that can be applied after refactoring was made cdtdoug: iplog+, anna.dushistova: review?

Description Anna Dushistova CLA 2010-06-25 17:32:22 EDT
From Marc's comment for bug 314659:
So, this Properties.. is a global setting, right?  Well, when I use it, it does
not work.  I set the skip download to enabled by default and the binary still
gets downloaded based on the launch checkbox.  If I create a new launch, it
does not take the global property either.
Comment 1 Marc Khouzam CLA 2010-06-25 20:44:50 EDT
This is the "properties" button in the Main tab of the Remote launch, next to the Connection.
Comment 2 Anna Dushistova CLA 2010-07-10 09:16:55 EDT
I tested it, it works except one thing: 
if you create launch configuration (default DSF launch) and then change the launcher to CDI it loses the properties, i.e. if you had "skip download" checked in properties, when you switch to CDI it becomes unchecked.
Comment 3 Anna Dushistova CLA 2010-07-10 12:03:40 EDT
Created attachment 173939 [details]
patch that enables saving
Comment 4 Marc Khouzam CLA 2010-07-11 21:09:35 EDT
(In reply to comment #2)
> I tested it, it works except one thing: 
> if you create launch configuration (default DSF launch) and then change the
> launcher to CDI it loses the properties, i.e. if you had "skip download"
> checked in properties, when you switch to CDI it becomes unchecked.

So when you use DSF and you set "skip download" in the Properties button, it sets the "skip download" in the launch also?
Comment 5 Anna Dushistova CLA 2010-07-12 09:15:03 EDT
(In reply to comment #4)
> (In reply to comment #2)
> > I tested it, it works except one thing: 
> > if you create launch configuration (default DSF launch) and then change the
> > launcher to CDI it loses the properties, i.e. if you had "skip download"
> > checked in properties, when you switch to CDI it becomes unchecked.
> 
> So when you use DSF and you set "skip download" in the Properties button, it
> sets the "skip download" in the launch also?

Yes. And if you switch to CDI debug, it should keep it as well.
Comment 6 Anna Dushistova CLA 2010-07-14 12:02:34 EDT
Created attachment 174312 [details]
same patch that can be applied after refactoring was made

Had to redo the patch because of remote launch plugin refactoring.
Comment 7 Ted Williams CLA 2010-07-19 12:15:28 EDT
committed