Bugzilla – Full Text Bug Listing
| Summary: | TextTransfer generates incorrect UTF16 in pasteboard when copying strings from SWT application | ||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | linyunzhi <linyunz> | ||||||||||||||||||||||||
| Component: | SWT | Assignee: | Scott Kovatch <skovatch> | ||||||||||||||||||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||||||||||||||||||
| Severity: | normal | ||||||||||||||||||||||||||
| Priority: | P3 | CC: | linyunz, mukund, raji, Silenio_Quarti, skovatch | ||||||||||||||||||||||||
| Version: | 3.5.2 | Flags: | Silenio_Quarti:
review+
|
||||||||||||||||||||||||
| Target Milestone: | 3.6.1 | ||||||||||||||||||||||||||
| Hardware: | Macintosh | ||||||||||||||||||||||||||
| OS: | Mac OS X - Carbon (unsup.) | ||||||||||||||||||||||||||
| Whiteboard: | |||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||
|
Description
linyunzhi
Created attachment 172576 [details]
CopyPasteTest.java
Created attachment 172577 [details]
Native Carbon application CHZO858ABV
The changes from 3.4.2 to 3.5.2 were done to fix bug#252109. Eclipse is putting "kUTTypeUTF16ExternalPlainText" data in the clipboard and the application is trying to get "kUTTypeUTF16PlainText". Some how PasteboardGetItemFlavorFlags() says that kUTTypeUTF16PlainText format is in the clipboard but PasteboardCopyItemFlavorData fails to get data in that format. It seems it cannot make the conversion from kUTTypeUTF16ExternalPlainText to kUTTypeUTF16PlainText I was wrong. PasteboardGetItemFlavorFlags does not say that kUTTypeUTF16PlainText data is in the clipboard. So it does not try to convert between kUTTypeUTF16PlainText and kUTTypeUTF16ExternalPlainText for free. I am not sure what to do here. Could the C application be changed to look for kUTTypeUTF16ExternalPlainText instead of kUTTypeUTF16PlainText? If we change SWT to put kUTTypeUTF16PlainText data in the clipboard, I am afraid that we will be putting bug#252109 back. I cannot check that because I do not have Entourage. Scott, do you believe this is true? (In reply to comment #5) > If we change SWT to put kUTTypeUTF16PlainText data in the clipboard, I am > afraid that we will be putting bug#252109 back. I cannot check that because I > do not have Entourage. Scott, do you believe this is true? kUTTypeUTF16PlainText is 'utxt', not 'TEXT'. It was using 'TEXT' that caused 252109. I think we want to put 'ut16' and 'utxt' on the pasteboard. I think the mistake in 252109 was that we took out 'utxt' and 'TEXT' and replaced them with 'ut16'. We just needed to remove 'TEXT' and use 'ut16' instead. I think I have Entourage here, so I will check to make sure. Created attachment 172674 [details]
patch for 3.5.2
This patch makes the C application work. Scott, please check Entourage? Should the encoding for UTXT be something else?
(In reply to comment #7) > Created an attachment (id=172674) [details] > patch for 3.5.2 > > This patch makes the C application work. Scott, please check Entourage? Should > the encoding for UTXT be something else? Okay, you beat me to it. I was getting ready to upload basically the same patch. Yes, this change still works when you copy from Eclipse and then paste into Entourage. In Widget.java, we're asking the clipboard for 'TEXT' -- should that be 'utxt' as well? Created attachment 172679 [details]
patch for 3.5.2
Yes and Widget.copyToClipboard() should put utxt and ut16 data to the clipboard otherwise Combo/Text copy would fail the same way.
Oops, patch is wrong (1 sec) Created attachment 172681 [details]
patch for 3.5.2
Ok, this is better.
I am wondering if we need to put both ut16 and utxt formats in the clipboard. It seems that utxt gets converted to ut16 for free. Would Entourage work if we only put utxt and utf8 data in the clipboard?
Created attachment 172683 [details]
patch that only puts UTXT and UTF8 data in clipboard
Scott, please try this one with Entourage.
Created attachment 172686 [details]
patch that only puts UTXT and UTF8 data in clipboard
This is the correct patch to add only UTXT and UTF8 to the clipboard.
Comment on attachment 172686 [details] patch that only puts UTXT and UTF8 data in clipboard Ok, I just confirmed that free conversion does NOT happen either way. So only patch from comment#11 is correct. (In reply to comment #14) Thanks Silenio & Scott! Yun Zhi if you can confirm this works for us we will get it into XPD build asap. Raji, we are still trying a few things. Please wait. OK, sorry for jumping the gun here. Created attachment 172695 [details]
Patch from 3.6
This patch reads and writes 'utxt' and 'utf8' to/from the clipboard. When we grab data with the 'utxt' flavor it's not in external representation (as opposed to 'ut16', so we have to pass false to CFStringCreateWithBytes so it can get the byte ordering correct.
Once I straightened that out, I changed the other places where we were still using 'ut16' and changed them to 'utxt' and not assuming external representation, for consistency. In practice it doesn't seem to matter based on the testing I did.
See the file UTCoreTypes.h for a description of the various pasteboard types. Note that Cocoa fails this test for the 'copy' button because our Text objects are plain-text. If they use RTF then the 'ut16' format gets written to the clipboard. Otherwise, just 'utxt' is written. Created attachment 172699 [details]
Patch for 3.5.2
Use this patch for the R3_5_maintenance branch.
Our Mac team has tested this privately and confirmed it fixes our problem. We will pull this into our builds. (In reply to comment #21) > Our Mac team has tested this privately and confirmed it fixes our problem. We > will pull this into our builds. We may tweak it a bit more today based on review and more testing. Once we move it to resolved/fixed you'll know we're all done. Good to know that it's working, though. Created attachment 172791 [details]
Revised patch
One last change (I think). After more research we should be writing 'utxt' for Unicode and 'TEXT' (for the current encoding) to the clipboard, and let consumers convert to other encodings as needed.
Created attachment 172793 [details]
Revised patch for 3.5 branch
Patch based on 3.5 maintenance branch.
Patches look good. The last patches visible here are the final ones. We're going to put the fix in 3.6.1 as well. We have verified the patch for 3.5 branch and it fixes the problem. Thanks very much ! Excellent! I will check this in to the 3.6 maintenance branch, and HEAD. Fixed in 3.6 branch and HEAD > 2010 06 28. |