Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317758

Summary: Key bindings for "Show History" don't work
Product: [Technology] Subversive Reporter: Raul Acevedo <raul>
Component: UIAssignee: Igor Burilo <igor.burilo>
Status: CLOSED DUPLICATE QA Contact:
Severity: normal    
Priority: P3 CC: a.gurov, pwebster, tomasz.zarna
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:

Description Raul Acevedo CLA 2010-06-23 20:18:51 EDT
Build Identifier: 20100617-1415

I want to bind a key to Team -> Show History, but nothing works.  No matter what keys I choose, nothing happens when I actually try it.  Team -> Show History will show my key binding in the menu, but when I hit those keys in a Java editor, nothing happens.

I've tried using key bindings that aren't defined anywhere else, and replacing existing bindings.  I always use "In Windows", and this is for SVN category.

Reproducible: Always

Steps to Reproduce:
1. Preferences -> Keys.
2. Add binding for "Show History", SVN category, In Windows, to say Ctrl+0.
3. Go to a Java editor window and type Ctrl+0.

I've tried other key bindings (i.e. binding keys to other commands) and that works fine.  For some reason only Show History is a problem.
Comment 1 Prakash Rangaraj CLA 2010-06-24 00:11:58 EDT
I tried to assign a shortcut for CVS show history. It works when the current active part is Package Explorer, but doesn't work when the Java editor is active. Assigning to Team for investigation
Comment 2 Tomasz Zarna CLA 2010-06-24 04:42:58 EDT
At first I thought it's another variation of bug 306173, but then I realized that I have a shortcut for "Show History" set so I gave it a try. I'm happy to say it does work for me in I20100608-0911 (3.6). Could you provide more detailed steps? What perspective are you using? Maybe a simple exported workspace could help me reproduce it.
Comment 3 Paul Webster CLA 2010-06-24 06:11:37 EDT
this is the SVN version, similar to bug 309074

PW
Comment 4 Tomasz Zarna CLA 2010-06-24 06:25:41 EDT
Moving to Subversion.
Comment 5 Paul Webster CLA 2010-06-24 07:56:26 EDT
See bug 306173 comment #16 for possible work-arounds (if SVN provides actionSets).

PW
Comment 6 Raul Acevedo CLA 2010-06-24 14:17:40 EDT
(In reply to comment #5)
> See bug 306173 comment #16 for possible work-arounds (if SVN provides
> actionSets).

The workaround of adding "Team" and "SVN" to Window > Customize Perspective... > Command Groups Availability worked.  Thank you very much!  Is this bug a dupe of 306173 then?
Comment 7 Tomasz Zarna CLA 2010-06-25 04:34:26 EDT
(In reply to comment #6)
>  Is this bug a dupe of 306173 then?

Nope, bug 306173 is for CVS actions only... unless SVN extends org.eclipse.team.internal.ui.actions.TeamAction which need the fix :) The class is internal so I'm pretty sure they do that. 

SVN will need to provide their own fix, see bug 309074, comment 16.
Comment 8 Raul Acevedo CLA 2010-09-24 17:01:39 EDT
The workaround mentioned in comment #5 does not fully work.  Often, I still can't use my key binding.  When this happens:

1.  It seems to be with XML files.  I.e. I click on an editor tab with an XML file.

2.  When it happens, my SVN menu greys everything out and only shows "Checkout projects from SVN".

The "workaround" is to click on another editor tab, and then back to the one I'm interested in.

I don't have an easy way to reproduce it... but at least with the workaround, it seems limited to XML files.
Comment 9 Alexander Gurov CLA 2012-02-20 09:59:25 EST
Duplicate.

*** This bug has been marked as a duplicate of bug 309074 ***