Bugzilla – Full Text Bug Listing
| Summary: | want DSF to open Memory Browser from Variable view | ||
|---|---|---|---|
| Product: | [Tools] CDT | Reporter: | Alain Lee <a-lee> |
| Component: | cdt-debug-dsf | Assignee: | Project Inbox <cdt-debug-dsf-inbox> |
| Status: | NEW --- | QA Contact: | Jonah Graham <jonah> |
| Severity: | major | ||
| Priority: | P3 | CC: | john.cortell, ken.ryall, marc.khouzam, normankyee, pawel.1.piech |
| Version: | 7.0 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows XP | ||
| Whiteboard: | |||
| Attachments: | |||
|
Description
Alain Lee
Good point. A preference maybe? I wish we'd instead address bug 294931 and rid ourselves of this silly situation of two views with the same purpose. (In reply to comment #2) > I wish we'd instead address bug 294931 and rid ourselves of this silly > situation of two views with the same purpose. I agree, that's the right way to handle this issue. Created attachment 203785 [details]
Added a "View memory with Memory Browser View" preference. If enabled, View Memory brings up the Memory Broswer View instead of the Memory View
Added a "View memory with Memory Browser View" checkbox to the Window->Preferences->Run/Debug->View Performance page. If this option is enabled, right clicking on a variable in the Variables view and selecting View Memory will show the variable's contents in the Memory Browser View instead of the Memory View.
I forgot to mention that you need the patch from this bug so that the DsfViewMemoryHandler can access the memory browser API: https://bugs.eclipse.org/bugs/show_bug.cgi?id=339708 (In reply to comment #4) > Created attachment 203785 [details] > Added a "View memory with Memory Browser View" preference. If enabled, View > Memory brings up the Memory Broswer View instead of the Memory View > > Added a "View memory with Memory Browser View" checkbox to the > Window->Preferences->Run/Debug->View Performance page. If this option is > enabled, right clicking on a variable in the Variables view and selecting View > Memory will show the variable's contents in the Memory Browser View instead of > the Memory View. I guess a preference is our last resort here which is better than having this bug. However, it should be in a memory-related page (like "Debug->Memory Browser") instead of "View Performance" Hi Pawel, I put the new preference on the "View Performance" page because the text at the top of that page says, "General settings for debuggers using Debug Services Framework(DSF)" and it seemed like the right place to put a DSF-related preference. I looked at the history and the page was named "DSF" at one time but was renamed to "View Performance." What do you think about renaming "View Performance" back to "DSF" and keeping the new preference on that page? (In reply to comment #7) > Hi Pawel, > > I put the new preference on the "View Performance" page because the text at the > top of that page says, "General settings for debuggers using Debug Services > Framework(DSF)" and it seemed like the right place to put a DSF-related > preference. I looked at the history and the page was named "DSF" at one time > but was renamed to "View Performance." What do you think about renaming "View > Performance" back to "DSF" and keeping the new preference on that page? Ken has renamed the preferences pages to be more user-friendly. I don't think using "DSF" will mean anything to a user. We should use a name that the user will think to look to to find the preferences in question. > Ken has renamed the preferences pages to be more user-friendly. I don't think
> using "DSF" will mean anything to a user. We should use a name that the user
> will think to look to to find the preferences in question.
That's a good point. I will move the preference to a Memory Browser preference page as Pawel suggested and update the patch.
Created attachment 203803 [details]
Moved preference to a new Run/Debug->Memory Browser preference page
|