Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317722

Summary: many "warnings" in download page scripts
Product: [WebTools] WTP Releng Reporter: David Williams <david_williams>
Component: relengAssignee: David Williams <david_williams>
Status: RESOLVED FIXED QA Contact: David Williams <david_williams>
Severity: normal    
Priority: P3    
Version: 3.10   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
syserr
none
sysout none

Description David Williams CLA 2010-06-23 11:58:45 EDT
Created attachment 172519 [details]
syserr

There's many "warnings" that are in our download page PHP scripts. Normally these are not displayed, and are no problem. But on "release day" our page could not be loaded fast enough, I had to investigate ... and I wonder if some of these warnings prevent proper caching of the page? 

I'll attached out.txt, and err.txt (sysout, and sysin from the php command). besides the misc. cleanup, a surprising one is the "SERVER_NAME" warning ... not so much there's a warning, but the fact that its missing appears to cause the "reminder, see also" message in the html (in out.txt) ... that's not right? And was the only thing preventing use of the out.txt file as "index.html". 
(I copied and hand edited the out.txt file, to create index.html file for faster serving ... seems we could almost do something similar all the time? In a more automated way, naturally.
Comment 1 David Williams CLA 2010-06-23 11:59:11 EDT
Created attachment 172520 [details]
sysout
Comment 2 David Williams CLA 2010-06-24 18:48:01 EDT
I'm going to remove the code around "server_name". I read on php docs, that it will always return nothing when ran from command line. And in some cases returns the server from the request header, and in some cases the server its running on. 

Doesn't seem like that important of a function anyway, to spend any time on it.
Comment 3 David Williams CLA 2010-06-25 00:46:27 EDT
fixed