Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317709

Summary: site.p2 product build always creates source feature
Product: z_Archived Reporter: Frank Hoellering <hoelle666>
Component: BuckminsterAssignee: buckminster.core-inbox <buckminster.core-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: info, thomas
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
Patch for fixing tutorial problems with buckminster 1.3.0 thomas: iplog+

Description Frank Hoellering CLA 2010-06-23 10:44:49 EDT 
Build Identifier: eclispe:20100617-1415, buckminster:1.3.0r11467

Invoking the site.p2 action on an rcp product always creates a source feature for the the main product feature though cbi.include.source=false is set.

Reproducible: Always

Steps to Reproduce:
1. use Helios with buckminster 1.3.0
2. checkout buckminster tutorial (o.e.buckminster.tutorial.mailapp, o.e.b.t.mailapp.product.feature, o.e.b.t.mailapp.releng, o.e.b.t.rcpp2.feature) from http://dev.eclipse.org/svnroot/tools/org.eclipse.buckminster/trunk/ (rev1142 when filing this bug)
3. apply attached patch to fix buckminster syntax changes
4. Invoke site.p2 action on o.e.b.t.mailapp.product.feature using the buckminster.properties file in o.e.b.t.mailapp.releng
5. Point the eclipse installer to the local directory ${user.home}/bmtutorial/org.eclipse.buckminster.tutorial.mailapp.product.feature_1.0.0-eclipse.feature/site.p2 , uncheck option "Group items by category"
6. A feature named "Source for Mailapp Feature" is displayed
Comment 1 Frank Hoellering CLA 2010-06-23 10:52:14 EDT 
Created attachment 172512 [details]
Patch for fixing tutorial problems with buckminster 1.3.0

This patch fixes a few problems with Eclispe 3.6/Buckminster 1.3.0
o removes dependency to org.eclipse.equinox.executable (fixed problem, that product build included a second eclipse.exe launcher)
o reader type eclipse.import is renamed to p2
o product.ant throws "URI not hierarchical" error because of duplicate "file:" prefix
Comment 2 Thomas Hallgren CLA 2010-07-19 05:06:29 EDT 
Frank, how is the patch related to the problem with the source features?
Comment 3 Thomas Hallgren CLA 2010-07-19 07:11:54 EDT 
In any case, patch looks good. It's now committed to trunk.
Comment 4 Thomas Hallgren CLA 2010-07-19 10:43:12 EDT 
Source problem fixed. Released to helios-maintenance, rev 11503.
Comment 5 Frank Hoellering CLA 2010-07-21 03:35:16 EDT 
Sorry for the late reply. I assume you already figured out that the patch was only necessary to get the described testcase up and running.

Thank you for fixing the the problem!