Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317621

Summary:	Empty product id results in "null" root artifact for the .eclipseproduct
Product:	[Eclipse Project] PDE	Reporter:	Andrew Niefer <aniefer>
Component:	Build	Assignee:	pde-build-inbox <pde-build-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	3.6
Target Milestone:	3.7 M1
Hardware:	PC
OS:	Linux
Whiteboard:

Description Andrew Niefer

2010-06-22 13:39:55 EDT

When generating the .eclipseproduct for a product built with p2, we create an IU named product.getProductId() + ".root.feature".  If the product does not have an id defined, then we get "null.root.feature".

We should instead use getId() which returns the uid if defined, otherwise the normal id.

Comment 1 Andrew Niefer

2010-06-22 13:49:12 EDT

Also, this id is being used as a key to get this extra IU required by the product, the ProductGenerator was actually using product.getId(), so if the uid != id, then we would be missing the .eclipseproduct file.

Comment 2 Andrew Niefer

2010-06-22 14:23:31 EDT

fixed