Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317580

Summary:

The functionality of ScopingNode#findImportingScopes is incorrect.

Product:

[Tools] PTP

Reporter:

Stas Negara <snegara2>

Component:

Photran.Refactoring Engine

Assignee:

Jeffrey Overbey <com-eclipse-dot-org>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

com-eclipse-dot-org

Version:

6.0

Target Milestone:

6.0.1

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Patch for Bugs 317580 and 317583	g.watson: iplog+

Description Stas Negara

2010-06-22 09:51:26 EDT

ScopingNode#findImportingScopes returns not only the importing scopes of a particular ScopingNode, but also all importing scopes of those scopes that are imported in this ScopingNode. Additionally, this method looks for importing scopes in an inefficient manner, which makes it very slow.

Comment 1 Jeffrey Overbey

2010-06-22 14:27:17 EDT

Created attachment 172448 [details]
Patch for Bugs 317580 and 317583

Comment 2 Jeffrey Overbey

2010-06-22 14:31:26 EDT

Thanks, Stas.  I have committed the fix to HEAD (Photran 7.0) as well as the ptp_4_0 branch (Photran 6.0.1).