Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317554

Summary: JSP Discoverer : managing javascript containing jsp scripts/actions
Product: [Modeling] MoDisco Reporter: Fabien Giquel <fabien.giquel>
Component: TechnologiesAssignee: Fabien Giquel <fabien.giquel>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: hugo.bruneliere, modisco.web-inbox, nicolas.guyomar
Version: 0.9.0Flags: fabien.giquel: indigo+
Target Milestone: 0.9.0 M1   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
a Javascript sample with JSP actions
none
org.eclipse.gmt.modisco.jee.jsp.discoverer fabien.giquel: iplog+

Description Fabien Giquel CLA 2010-06-22 05:10:00 EDT 
When some Javascript contains JSP expressions, scriptlets, or actions, the javascript content is not analysed and represented with one single String content.

It is whishable to retrieve JSP parts as instances of JSPExpression, JSPScriptlet, JSPAction owned by the JavaScript instance. As it was done for attribute values using the ComposedAttribute metaclass.
Comment 1 Fabien Giquel CLA 2010-06-22 05:35:53 EDT 
Created attachment 172401 [details]
a Javascript sample with JSP actions

I attach a sample of Javascript with JSP actions.
Comment 2 Nicolas Guyomar CLA 2010-06-22 10:51:01 EDT 
Hi Fabien,

Please find attached a patch to update the grammar so that it takes in account JSP elements contained in JavaScript code.

1. I, Nicolas Guyomar, and others contributors listed in this bug, authored
100% of the content
2. I have the rights to donate the content to Eclipse under the EPL
3. I have already provided the filled Employer Consent Forms to the Foundation

Regards 
Nicolas
Comment 3 Nicolas Guyomar CLA 2010-06-22 10:52:04 EDT 
Created attachment 172420 [details]
org.eclipse.gmt.modisco.jee.jsp.discoverer

This patch update the JavaScript grammar's rule to parse JSP Element inside Javascript piece of code
Comment 4 Fabien Giquel CLA 2010-06-22 12:29:00 EDT 
Comment on attachment 172420 [details]
org.eclipse.gmt.modisco.jee.jsp.discoverer

JSP discoverer patch for JavaScript
Comment 5 Fabien Giquel CLA 2010-06-22 12:32:18 EDT 
Thanks for this patch Nicolas.
The contribution is less than 250 lines of code.
The code has been commited into SVN.
Comment 6 Hugo Bruneliere CLA 2010-10-04 13:45:18 EDT 
The patch has been successfully applied.