Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317538

Summary: Need a marker attribute to store extra problem parameters
Product: [Tools] CDT Reporter: Elena Laskavaia <elaskavaia.cdt>
Component: cdt-codanAssignee: Elena Laskavaia <elaskavaia.cdt>
Status: RESOLVED FIXED QA Contact: Elena Laskavaia <elaskavaia.cdt>
Severity: normal    
Priority: P3 CC: cdtdoug
Version: 7.0   
Target Milestone: 8.0   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Elena Laskavaia CLA 2010-06-21 20:19:44 EDT
Framework should provide a mechanism to store some extra information, not
visible in the error message for each problem. It can be retrieved by quick fix tools or other components (i.e. problem details view).
Comment 1 Elena Laskavaia CLA 2010-06-21 20:23:53 EDT
To implement this I am thinking to add one extra parameter, which would hold
list of strings, which represent list of arguments which checker passes to the reportProblem method. The ones are not used by message itself are hidden. There should be an utility that provides index-based access to these attributes.
i.e.

String getProblemArgument(IMarker marker, int index);
Comment 2 Elena Laskavaia CLA 2010-06-21 22:17:00 EDT
Implemented as describe above. Method added to AbstractCodanCMarkerResolution.
Comment 3 CDT Genie CLA 2010-06-21 22:23:03 EDT
*** cdt cvs genie on behalf of elaskavaia ***
Bug 317538: added framework to store arguments in a marker (add added intermediate object between reporter and marker)

[*] AssignmentInConditionCheckerTest.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core.test/src/org/eclipse/cdt/codan/core/internal/checkers/AssignmentInConditionCheckerTest.java?root=Tools_Project&r1=1.1&r2=1.2

[*] AbstractCodanCMarkerResolution.java 1.2 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.ui/src/org/eclipse/cdt/codan/ui/AbstractCodanCMarkerResolution.java?root=Tools_Project&r1=1.1&r2=1.2

[*] CodanApplication.java 1.8 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core/src/org/eclipse/cdt/codan/internal/core/CodanApplication.java?root=Tools_Project&r1=1.7&r2=1.8

[*] CodanMarkerProblemReporter.java 1.17 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core/src/org/eclipse/cdt/codan/internal/core/model/CodanMarkerProblemReporter.java?root=Tools_Project&r1=1.16&r2=1.17
[+] CodanProblemMarker.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core/src/org/eclipse/cdt/codan/internal/core/model/CodanProblemMarker.java?root=Tools_Project&revision=1.1&view=markup

[*] plugin.xml 1.12 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core/plugin.xml?root=Tools_Project&r1=1.11&r2=1.12

[+] AbstractProblemReporter.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core/src/org/eclipse/cdt/codan/core/model/AbstractProblemReporter.java?root=Tools_Project&revision=1.1&view=markup
[+] ICodanProblemMarker.java  http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core/src/org/eclipse/cdt/codan/core/model/ICodanProblemMarker.java?root=Tools_Project&revision=1.1&view=markup
[*] IProblemReporter.java 1.7 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.core/src/org/eclipse/cdt/codan/core/model/IProblemReporter.java?root=Tools_Project&r1=1.6&r2=1.7
Comment 4 Elena Laskavaia CLA 2010-06-21 22:53:09 EDT
fixed on head
Comment 5 CDT Genie CLA 2010-06-21 23:23:02 EDT
*** cdt cvs genie on behalf of elaskavaia ***
Bug 317538: added access methods to details provider as well

[*] AbstractCodanProblemDetailsProvider.java 1.9 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/codan/org.eclipse.cdt.codan.ui/src/org/eclipse/cdt/codan/ui/AbstractCodanProblemDetailsProvider.java?root=Tools_Project&r1=1.8&r2=1.9
Comment 6 Elena Laskavaia CLA 2010-06-23 21:22:19 EDT
resolved