Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 317521

Summary:

make attachments comment optional

Product:

z_Archived

Reporter:

Thomas Ehrnhoefer <thomas.ehrnhoefer>

Component:

Mylyn

Assignee:

Project Inbox <mylyn-triaged>

Status:

CLOSED MOVED

QA Contact:

Severity:

enhancement

Priority:

CC:

shawn.minto, thomas.ehrnhoefer

Version:

unspecified

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
patch v1	thomas.ehrnhoefer: review?
mylyn/context/zip	none

Description Thomas Ehrnhoefer

2010-06-21 17:31:16 EDT

Some repositories don't support comments. The attachments wizard page should have a "setNeedsComment" to show/hide the comments editor

Comment 1 Thomas Ehrnhoefer

2010-06-21 17:46:14 EDT

Created attachment 172377 [details]
patch v1

Comment 2 Thomas Ehrnhoefer

2010-06-21 17:46:17 EDT

Created attachment 172378 [details]
mylyn/context/zip

Comment 3 Steffen Pingel

2010-07-02 14:20:23 EDT

Thanks for the patch Thomas. Currently, repository connectors that do not support comments are not very well supported by the framework. The attach context dialog for instance makes the same assumption that it is always possible to submit a comment along with an attachment.

It seems to me that support for comments should be a capability on AbstractRepositoryConnector or part of the attachment data model rather than something that is handled on the UI level. What are your thoughts?

Comment 4 Thomas Ehrnhoefer

2010-07-03 16:00:39 EDT

Sure, that sounds reasonable. I will rewrite the patch

Comment 5 Eclipse Webmaster

2022-11-15 11:45:08 EST

Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn